Our Market.Sol smart Contracts calls the transferFrom() function on any provided nftContract address. These may not always be valid IERC721 compliant smart contract addresses. Is this a security vulnerability? Confirm that this is either a safe assumption to make or what can be done to improve such calls.
Example:
|
IERC721(nftContract).transferFrom(msg.sender, address(this), tokenId); |
|
return itemId; |
This tweet suggests using safeTransferFrom. See: https://gist.github.com/ecmendenhall/9408082d8f3cfe50076642d8745fc6d3
Our Market.Sol smart Contracts calls the
transferFrom()function on any providednftContractaddress. These may not always be validIERC721compliant smart contract addresses. Is this a security vulnerability? Confirm that this is either a safe assumption to make or what can be done to improve such calls.Example:
arthouse/contracts/Market.sol
Lines 107 to 108 in a49bd90
This tweet suggests using safeTransferFrom. See: https://gist.github.com/ecmendenhall/9408082d8f3cfe50076642d8745fc6d3