Repository navigation
fdbcli: mention hostnames in the coordinators help text - #14342
Merged
Merged
Conversation
The coordinators help text said the command takes a list of IP:port pairs, and architecture.rst and kv-architecture.rst said the cluster file contains the IP:PORT of the coordinators. Hostnames are accepted for coordinators, and a hostname must resolve when the command runs. Update the help text and both architecture docs to say so.
saintstack
approved these changes
Oct 21, 2026
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Contributor
|
Thank you for the contribution @VanshBhardwaj24 |
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14289 documents that coordinators can be given as hostnames. This brings the remaining places in line, which the review there suggested as a follow-up:
fdbclihelp text forcoordinatorssaid the command takes "IP:port pairs". It now says "IP:port or hostname:port pairs", and that a hostname must resolve when the command runs (changeQuorumCheckerreturnsCOORDINATOR_UNREACHABLEif any hostname is unresolvable,fdbclient/ManagementAPI.cpp).architecture.rstandkv-architecture.rstsaid the cluster file contains "the IP:PORT of the coordinators". They now say "IP:PORT or HOSTNAME:PORT".Validation:
clang-format-19 --dry-run -Werrorpasses onfdbcli/CoordinatorsCommand.cpp, the Sphinx 6.2.1 HTML build passes with warnings treated as errors, andgit diff --checkis clean. Nothing in the tests or docs matches the old help text. The changed string was not compiled andfdbcliwas not run.Help-text and docs change only; no behavior is affected.