Skip to content

Share process-class special-key row construction - #14331

Merged
tclinkenbeard-oai merged 2 commits into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/share-process-class-rows
Oct 22, 2026
Merged

tclinkenbeard-oai merged 2 commits into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/share-process-class-rows

Conversation

@tclinkenbeard-oai

@tclinkenbeard-oai tclinkenbeard-oai commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

The process class-type and class-source special-key readers duplicate endpoint sorting, deduplication, range filtering, and row construction. Share that work in a private synchronous helper, selecting either the class name or its source as the row value.

Both callers move their worker vectors into the helper. Lexical endpoint ordering, TLS suffix omission, duplicate handling, and range boundaries are preserved. Keys and values belong to the returned result arena, and only the writable class-type view applies read-your-writes.

Validation: changed-line clang-format 19, git diff --check, source invariants, and independent review pass. Compilation and the existing SpecialKeySpace correctness/robustness simulations remain unrun because the remote validation environment is unavailable.

@tclinkenbeard-oai
tclinkenbeard-oai marked this pull request as ready for review October 20, 2026 17:56
@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 5f0dd8a
  • Duration 0:34:26
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux RHEL 9

  • Commit ID: 5f0dd8a
  • Duration 0:48:35
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 5f0dd8a
  • Duration 1:04:01
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 5f0dd8a
  • Duration 1:07:09
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 5f0dd8a
  • Duration 1:45:15
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS 14.x

  • Commit ID: 5f0dd8a
  • Duration 2:12:28
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS 14.x

  • Commit ID: 5f0dd8a
  • Duration 3:23:49
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

This comment has been minimized.

@tclinkenbeard-oai
tclinkenbeard-oai merged commit 37683a2 into apple:main Oct 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants