Repository navigation
Share process-class special-key row construction - #14331
Merged
tclinkenbeard-oai merged 2 commits intoOct 22, 2026
Merged
tclinkenbeard-oai merged 2 commits into
tclinkenbeard-oai merged 2 commits into
Conversation
tclinkenbeard-oai
marked this pull request as ready for review
October 20, 2026 17:56
This comment has been minimized.
This comment has been minimized.
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
This comment has been minimized.
This comment has been minimized.
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
This comment has been minimized.
This comment has been minimized.
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
This comment has been minimized.
This comment has been minimized.
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
This comment has been minimized.
This comment has been minimized.
saintstack
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The process class-type and class-source special-key readers duplicate endpoint sorting, deduplication, range filtering, and row construction. Share that work in a private synchronous helper, selecting either the class name or its source as the row value.
Both callers move their worker vectors into the helper. Lexical endpoint ordering, TLS suffix omission, duplicate handling, and range boundaries are preserved. Keys and values belong to the returned result arena, and only the writable class-type view applies read-your-writes.
Validation: changed-line clang-format 19,
git diff --check, source invariants, and independent review pass. Compilation and the existing SpecialKeySpace correctness/robustness simulations remain unrun because the remote validation environment is unavailable.