THRIFT-6213: Define the TConfiguration default constants in the library

Client: cpp

An odr-used static const data member needs this out-of-line definition in
every C++ standard; drop it only once the constants become inline
constexpr.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: 2 people

lib/cpp/CMakeLists.txt

@@ -30,6 +30,7 @@ endif()
 # Create the thrift C++ library
 set(thriftcpp_SOURCES
    src/thrift/TApplicationException.cpp
+   src/thrift/TConfiguration.cpp
    src/thrift/TOutput.cpp
    src/thrift/TUuid.cpp
    src/thrift/async/TAsyncChannel.cpp

lib/cpp/Makefile.am

@@ -56,6 +56,7 @@ AM_CPPFLAGS = $(BOOST_CPPFLAGS) $(OPENSSL_INCLUDES) -I$(srcdir)/src -D__STDC_FOR
 # Define the source files for the module
 
 libthrift_la_SOURCES = src/thrift/TApplicationException.cpp \
+                       src/thrift/TConfiguration.cpp \
                        src/thrift/TOutput.cpp \
                        src/thrift/TUuid.cpp \
                        src/thrift/VirtualProfiling.cpp \

lib/cpp/libthrift.vcxproj

@@ -56,6 +56,7 @@
     <ClCompile Include="src\thrift\server\TThreadedServer.cpp" />
     <ClCompile Include="src\thrift\server\TThreadPoolServer.cpp" />
     <ClCompile Include="src\thrift\TApplicationException.cpp" />
+    <ClCompile Include="src\thrift\TConfiguration.cpp" />
     <ClCompile Include="src\thrift\TOutput.cpp" />
     <ClCompile Include="src\thrift\TUuid.cpp" />
     <ClCompile Include="src\thrift\transport\SocketCommon.cpp" />

lib/cpp/libthrift.vcxproj.filters

@@ -7,6 +7,7 @@
     <ClCompile Include="src\thrift\TUuid.cpp" />
     <ClCompile Include="src\thrift\TOutput.cpp" />
     <ClCompile Include="src\thrift\TApplicationException.cpp" />
+    <ClCompile Include="src\thrift\TConfiguration.cpp" />
     <ClCompile Include="src\thrift\transport\TTransportException.cpp">
       <Filter>transport</Filter>
     </ClCompile>

lib/cpp/src/thrift/TConfiguration.cpp

@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <thrift/TConfiguration.h>
+
+namespace apache {
+namespace thrift {
+
+// Binding one of these constants to a reference, as std::make_shared or
+// std::min do, needs this definition for as long as the header declares them
+// static const rather than inline constexpr, in every C++ standard.
+const int TConfiguration::DEFAULT_MAX_MESSAGE_SIZE;
+const int TConfiguration::DEFAULT_MAX_FRAME_SIZE;
+const int TConfiguration::DEFAULT_RECURSION_DEPTH;
+
+}
+} // apache::thrift

lib/cpp/test/TTransportFactoryConfigTest.cpp

@@ -349,3 +349,17 @@ BOOST_AUTO_TEST_CASE(test_framed_transport_default_constructor_initialises_max_f
   TFramedTransport wrapped(std::make_shared<TMemoryBuffer>(), config);
   BOOST_CHECK_EQUAL(wrapped.getMaxFrameSize(), static_cast<uint32_t>(kMaxFrameSize));
 }
+
+// Binding a default to a reference or taking its address needs the library to
+// define it. Reading the addresses through volatile pointers keeps an
+// optimising compiler from folding the references away (THRIFT-6213).
+BOOST_AUTO_TEST_CASE(test_configuration_defaults_are_defined) {
+  const int* volatile maxMessageSize = &TConfiguration::DEFAULT_MAX_MESSAGE_SIZE;
+  const int* volatile maxFrameSize = &TConfiguration::DEFAULT_MAX_FRAME_SIZE;
+  const int* volatile recursionDepth = &TConfiguration::DEFAULT_RECURSION_DEPTH;
+
+  const TConfiguration config;
+  BOOST_CHECK_EQUAL(*maxMessageSize, config.getMaxMessageSize());
+  BOOST_CHECK_EQUAL(*maxFrameSize, config.getMaxFrameSize());
+  BOOST_CHECK_EQUAL(*recursionDepth, config.getRecursionLimit());
+}