You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 50bbda1
Browse filesBrowse the repository at this point in the historyBrowse files
THRIFT-6401: Declare the minimum Visual C++ runtime for WinGet and Chocolatey, and drop the dead Chocolatey icon
Client: build
The Chocolatey review of the thrift 0.25.0 package flagged the nuspec's
iconUrl, which returns 404, and a dependency without a version. There
is no square Thrift logo to point at, so the package goes without an
icon, as the 0.12.0 package did.
The released thrift.exe links the shared Visual C++ runtime, and the
installed redistributable has to be at least as new as the build tools
the program was built with; thrift-0.25.0.exe reports linker version
14.51. Without a minimum, any vcredist140 that is already installed
satisfies the dependency and is not updated, and the WinGet manifest
had the same gap. The nuspec now asks for vcredist140 14.51 or later,
and the WinGet installer manifest asks for Microsoft.VCRedist.2015+.x64
14.51 or later through MinimumVersion, quoted so that YAML keeps it a
string.
The tests check both minimums, that the two agree, and that the nuspec
names no icon. doc/ReleaseManagement.md says to raise the minimum when
the compiler is built with newer build tools, and build/windows/README.md
mentions it.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: doc/ReleaseManagement.md
+7Lines changed: 7 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -205,6 +205,13 @@ All Apache Thrift releases go through a 72-hour final release candidate voting p
205
205
Do **not** build a statically linked compiler to make that list shorter. The
206
206
project moved away from one deliberately, and the released compiler is expected
207
207
to require the Visual C++ redistributable; the check fails if it does not.
208
+
209
+
The installed redistributable has to be at least as new as the build tools the
210
+
compiler was built with, so the WinGet and Chocolatey packages ask for that version
211
+
or later: 14.51, what 0.25.0 was built with. If you build with newer build tools -
212
+
`dumpbin /headers thrift.exe` shows their version as the linker version - raise
213
+
`MinimumVersion`in`build/windows/winget/Apache.Thrift.installer.yaml.in` and the
214
+
`vcredist140` version in`build/windows/chocolatey/thrift.nuspec.in` to match.
208
215
1. Copy the executable `thrift.exe` to your linux system where the signed tarball lives and rename it to `thrift-1.0.0.exe` (substitute the correct version, of course).
209
216
1. Sign the executable the same way you signed the tarball.
210
217
1. Build the Windows installer from the very same executable:
0 commit comments