review license setup on dev_tools/language_server/tests/conftest.py

[pjfanning]

hamilton/dev_tools/language_server/tests/conftest.py

Line 4 in e033338

# See ThirdPartyNotices.txt in the project root for license information. #

There is no ThirdPartyNotices.txt

• The whole comment seems like it needs to be fixed up.
• We need to update our LICENSE file to mention this file and its license

@skrawcz could you or another nominated PPMC member find out where this file originates and what the original source code headers were. We also need to work out which bits are MIT licensed and which are Apache licensed.

[pjfanning]

@skrawcz @Dev-iL This needs to be addressed. We should also mention conftest.py in the root LICENSE file.

[pjfanning]

Is this maybe based on https://github.com/openlawlibrary/pygls/blob/main/tests/conftest.py ?

Could we rewrite the file to remove anything that comes from there? If we remove the Palantir/Open Law Library code and write our code to replace it - this whole licensing mess disappears.

[Dev-iL]

Could we rewrite the file to remove anything that comes from there? If we remove the Palantir/Open Law Library code and write our code to replace it - this whole licensing mess disappears.

1. How to tell what exactly comes from there?
2. To elaborate on what I mentioned in Use a short SPDX license header for LLM-centered files #1489 (comment) - the code in question is a very standard boilerplate conftest.py (a pytest configuration) and Hamilton's version is already quite different from the source (to the point that it may be considered rewritten anyway). Therefore, according to my reasoning, it can hardly be considered derivative work - and therefore does not require the license.

[pjfanning]

I'm happy to say the code has been rewritten if more people agree that it is. It would make life much easier if we can remove the source header from that file altogether and replace it with a standard Apache license header. But we can only do that if it is widely agreed that the Palantir/Open Law Library code is gone.