[#14105] test: Replace the last JUnit 4 code and declare the test libraries each module uses

Author: nevzheng

authorizations/authorization-chain/src/test/java/org/apache/gravitino/authorization/chain/integration/test/TestChainedAuthorizationIT.java

@@ -326,67 +326,80 @@ public void testCreateSchema() throws InterruptedException {
   }
 
   @Test
-  void testCreateTable() throws InterruptedException {
+  @Override
+  protected void testCreateTable() {
     // TODO
   }
 
   @Test
-  void testSelectModifyTableWithMetalakeLevelRole() throws InterruptedException {
+  @Override
+  protected void testSelectModifyTableWithMetalakeLevelRole() {
     // TODO
   }
 
   @Test
-  void testSelectModifyTableWithTableLevelRole() throws InterruptedException {
+  @Override
+  protected void testSelectModifyTableWithTableLevelRole() {
     // TODO
   }
 
   @Test
-  void testSelectOnlyTable() throws InterruptedException {
+  @Override
+  protected void testSelectOnlyTable() {
     // TODO
   }
 
   @Test
-  void testModifyOnlyTable() throws InterruptedException {
+  @Override
+  protected void testModifyOnlyTable() {
     // TODO
   }
 
   @Test
-  void testCreateAllPrivilegesRole() throws InterruptedException {
+  @Override
+  protected void testCreateAllPrivilegesRole() {
     // TODO
   }
 
   @Test
-  void testDeleteAndRecreateRole() throws InterruptedException {
+  @Override
+  protected void testDeleteAndRecreateRole() {
     // TODO
   }
 
   @Test
-  void testDeleteAndRecreateMetadataObject() throws InterruptedException {
+  @Override
+  protected void testDeleteAndRecreateMetadataObject() {
     // TODO
   }
 
   @Test
-  void testRenameMetadataObject() throws InterruptedException {
+  @Override
+  protected void testRenameMetadataObject() {
     // TODO
   }
 
   @Test
-  void testRenameMetadataObjectPrivilege() throws InterruptedException {
+  @Override
+  protected void testRenameMetadataObjectPrivilege() {
     // TODO
   }
 
   @Test
-  void testChangeOwner() throws InterruptedException {
+  @Override
+  protected void testChangeOwner() {
     // TODO
   }
 
   @Test
-  void testDenyPrivileges() throws InterruptedException {
+  @Override
+  protected void testDenyPrivileges() {
     // TODO
   }
 
   @Test
-  void testGrantPrivilegesForMetalake() throws InterruptedException {
+  @Override
+  protected void testGrantPrivilegesForMetalake() {
     // TODO
   }
 

authorizations/authorization-ranger/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerBaseE2EIT.java

@@ -279,7 +279,7 @@ void checkCreateTable() {
   }
 
   @Test
-  void testCreateTable() {
+  protected void testCreateTable() {
     // Choose a catalog
     reset();
 
@@ -345,7 +345,7 @@ void checkCreateTable() {
   }
 
   @Test
-  void testSelectModifyTableWithMetalakeLevelRole() {
+  protected void testSelectModifyTableWithMetalakeLevelRole() {
     // Choose a catalog
     reset();
 
@@ -430,7 +430,7 @@ protected abstract static class TestSelectModifyTableChecker {
   }
 
   @Test
-  void testSelectModifyTableWithTableLevelRole() {
+  protected void testSelectModifyTableWithTableLevelRole() {
     // Choose a catalog
     reset();
 
@@ -496,7 +496,7 @@ void testSelectModifyTableWithTableLevelRole() {
   }
 
   @Test
-  void testSelectOnlyTable() {
+  protected void testSelectOnlyTable() {
     // Choose a catalog
     reset();
 
@@ -603,7 +603,7 @@ protected abstract static class TestSelectOnlyTableChecker {
   }
 
   @Test
-  void testModifyOnlyTable() {
+  protected void testModifyOnlyTable() {
     // Choose a catalog
     reset();
 
@@ -686,7 +686,7 @@ protected abstract static class TestModifyOnlyTableChecker {
   }
 
   @Test
-  void testCreateAllPrivilegesRole() {
+  protected void testCreateAllPrivilegesRole() {
     // Choose a catalog
     reset();
 
@@ -735,7 +735,7 @@ void testCreateAllPrivilegesRole() {
   }
 
   @Test
-  void testDeleteAndRecreateRole() {
+  protected void testDeleteAndRecreateRole() {
     // Choose a catalog
     reset();
 
@@ -801,7 +801,7 @@ void checkCreateSchema() {
   }
 
   @Test
-  void testDeleteAndRecreateMetadataObject() {
+  protected void testDeleteAndRecreateMetadataObject() {
     // Choose a catalog
     reset();
 
@@ -872,7 +872,7 @@ void checkRecreateSchema() {
   }
 
   @Test
-  void testRenameMetadataObject() {
+  protected void testRenameMetadataObject() {
     // Choose a catalog
     reset();
 
@@ -910,7 +910,7 @@ void testRenameMetadataObject() {
   }
 
   @Test
-  void testRenameMetadataObjectPrivilege() {
+  protected void testRenameMetadataObjectPrivilege() {
     // Choose a catalog
     reset();
 
@@ -959,7 +959,7 @@ void testRenameMetadataObjectPrivilege() {
   }
 
   @Test
-  void testChangeOwner() {
+  protected void testChangeOwner() {
     // Choose a catalog
     reset();
 
@@ -1183,7 +1183,7 @@ void checkShowSchemasAgain() {
     }
   }
 
-  void testDenyPrivileges() {
+  protected void testDenyPrivileges() {
     // Choose a catalog
     reset();
 
@@ -1248,7 +1248,7 @@ void testDenyPrivileges() {
 
   // ISSUE-5892 Fix to grant privilege for the metalake
   @Test
-  void testGrantPrivilegesForMetalake() {
+  protected void testGrantPrivilegesForMetalake() {
     // Choose a catalog
     reset();
 

build.gradle.kts

@@ -583,6 +583,7 @@ fun excludePackagesForSparkConnector(project: Project) {
 }
 
 val commonsBeanutilsVersion: String = libs.versions.commons.beanutils.get()
+val checkstyleVersion: String = libs.versions.checkstyle.get()
 
 subprojects {
   // Gravitino Python client project didn't need to apply the java plugin
@@ -613,6 +614,17 @@ subprojects {
     exclude(group = "log4j", module = "log4j")
   }
 
+  // Checkstyle carries only the import bans Spotless cannot express, such as JUnit 4.
+  apply(plugin = "checkstyle")
+  configure<CheckstyleExtension> {
+    toolVersion = checkstyleVersion
+    configFile = rootProject.file("config/checkstyle/checkstyle.xml")
+    maxWarnings = 0
+  }
+  // The import bans need no type information; an empty classpath keeps checkstyle from building
+  // other modules' test jars.
+  tasks.withType<Checkstyle>().configureEach { classpath = files() }
+
   repositories {
     mavenCentral()
     mavenLocal()

catalogs-contrib/catalog-jdbc-hologres/src/test/java/org/apache/gravitino/catalog/hologres/integration/test/CatalogHologresIT.java

@@ -27,6 +27,7 @@
 import java.util.Map;
 import java.util.Set;
 import java.util.stream.Collectors;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.gravitino.Catalog;
 import org.apache.gravitino.NameIdentifier;
 import org.apache.gravitino.Namespace;
@@ -63,7 +64,6 @@
 import org.junit.jupiter.api.TestInstance.Lifecycle;
 import org.junit.jupiter.api.condition.EnabledIf;
 import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable;
-import org.junit.platform.commons.util.StringUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

catalogs/catalog-fileset/src/test/java/org/apache/gravitino/catalog/fileset/integration/test/FilesetABSCatalogIT.java

@@ -25,6 +25,7 @@
 import java.io.IOException;
 import java.net.URI;
 import java.util.Map;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.gravitino.Catalog;
 import org.apache.gravitino.NameIdentifier;
 import org.apache.gravitino.Schema;
@@ -39,7 +40,6 @@
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.condition.EnabledIf;
-import org.junit.platform.commons.util.StringUtils;
 
 @EnabledIf("absIsConfigured")
 public class FilesetABSCatalogIT extends FilesetCatalogIT {

catalogs/catalog-fileset/src/test/java/org/apache/gravitino/catalog/fileset/integration/test/FilesetCOSCatalogIT.java

@@ -26,6 +26,7 @@
 import java.io.IOException;
 import java.net.URI;
 import java.util.Map;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.gravitino.Catalog;
 import org.apache.gravitino.NameIdentifier;
 import org.apache.gravitino.Schema;
@@ -40,7 +41,6 @@
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.condition.EnabledIf;
-import org.junit.platform.commons.util.StringUtils;
 
 /**
  * Integration test for the fileset catalog backed by Tencent Cloud COS. It is disabled unless the

catalogs/catalog-fileset/src/test/java/org/apache/gravitino/catalog/fileset/integration/test/FilesetOSSCatalogIT.java

@@ -26,6 +26,7 @@
 import java.io.IOException;
 import java.net.URI;
 import java.util.Map;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.gravitino.Catalog;
 import org.apache.gravitino.NameIdentifier;
 import org.apache.gravitino.Schema;
@@ -40,7 +41,6 @@
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.condition.EnabledIf;
-import org.junit.platform.commons.util.StringUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

catalogs/catalog-jdbc-common/build.gradle.kts

@@ -68,6 +68,7 @@ dependencies {
   testImplementation(libs.mockito.core)
   testImplementation(libs.sqlite.jdbc)
   testImplementation(libs.testcontainers)
+  testImplementation(libs.testcontainers.jdbc)
   testImplementation(libs.testcontainers.mysql)
   testImplementation(libs.testcontainers.postgresql)
 

catalogs/catalog-jdbc-doris/src/test/java/org/apache/gravitino/catalog/doris/operation/TestDorisTableOperations.java

@@ -18,8 +18,8 @@
  */
 package org.apache.gravitino.catalog.doris.operation;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import com.google.common.collect.Maps;
 import java.sql.Connection;

catalogs/catalog-jdbc-doris/src/test/java/org/apache/gravitino/catalog/doris/operation/TestDorisTablePartitionOperations.java

@@ -18,10 +18,10 @@
  */
 package org.apache.gravitino.catalog.doris.operation;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertThrows;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import com.google.common.collect.ImmutableMap;
 import java.sql.Connection;