PR pickup time is considering any comment rather than review comment #8317
Unanswered
AnkeshThakur
asked this question in
Q&A
Replies: 4 comments
|
Make sense, would you like to put up an PR for that? |
0 replies
|
Yes. Sure thing! |
0 replies
|
Nice, looking forward to it. |
0 replies
|
is this fixed? |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
The PR pickup time calculation in DORA does not account for review comment. It picks any type of comment for calculation. Any automation (CI/bots etc) can comment on the PR and it would consider it to be picked up.
Code - https://github.com/apache/incubator-devlake/blob/e0584d67f543ec4e736950e51792922779e4d759/backend/plugins/dora/tasks/change_lead_time_calculator.go#L183-L191
It should filter based on comment type 'REVIEW' and first review comment's timestamp should be used for pickup time calculation. In case there is no review comment, pickup time should be equal to time diff between created_date and merge date.
All reactions