Skip to content

Commit 59aeca9

Browse files
committed
feat(ios): Fix some comments in CDVCamera
- Make some long method declarations multi-line instead single-line
1 parent edc2832 commit 59aeca9

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

src/ios/CDVCamera.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ typedef NSUInteger CDVMediaType;
129129
- (void)cleanup:(CDVInvokedUrlCommand*)command;
130130
- (void)repositionPopover:(CDVInvokedUrlCommand*)command;
131131

132+
// UIImagePickerControllerDelegate methods
132133
- (void)imagePickerController:(UIImagePickerController*)picker didFinishPickingMediaWithInfo:(NSDictionary*)info;
133134
- (void)imagePickerController:(UIImagePickerController*)picker didFinishPickingImage:(UIImage*)image editingInfo:(NSDictionary*)editingInfo;
134135
- (void)imagePickerControllerDidCancel:(UIImagePickerController*)picker;
@@ -144,6 +145,7 @@ typedef NSUInteger CDVMediaType;
144145
- (void)showPHPicker:(NSString*)callbackId withOptions:(CDVPictureOptions*)pictureOptions API_AVAILABLE(ios(14));
145146
- (void)processPHPickerImage:(UIImage*)image assetIdentifier:(NSString*)assetIdentifier callbackId:(NSString*)callbackId options:(CDVPictureOptions*)options API_AVAILABLE(ios(14));
146147
- (void)finalizePHPickerImage:(UIImage*)image metadata:(NSDictionary*)metadata callbackId:(NSString*)callbackId options:(CDVPictureOptions*)options API_AVAILABLE(ios(14));
148+
// PHPickerViewControllerDelegate method
147149
- (void)picker:(PHPickerViewController *)picker didFinishPicking:(NSArray<PHPickerResult *> *)results API_AVAILABLE(ios(14));
148150

149151
@end

src/ios/CDVCamera.m

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -967,9 +967,9 @@ - (void)imagePickerControllerReturnImageResult
967967
}
968968
}
969969

970-
#pragma mark PHPickerViewControllerDelegate methods
970+
#pragma mark PHPickerViewController related methods iOS 14+
971971

972-
// PHPickerViewController Delegate Methods (iOS 14+)
972+
// PHPickerViewControllerDelegate method
973973
- (void)picker:(PHPickerViewController *)picker didFinishPicking:(NSArray<PHPickerResult *> *)results API_AVAILABLE(ios(14))
974974
{
975975
NSString *callbackId = objc_getAssociatedObject(picker, "callbackId");
@@ -1029,7 +1029,10 @@ - (void)picker:(PHPickerViewController *)picker didFinishPicking:(NSArray<PHPick
10291029
}];
10301030
}
10311031

1032-
- (void)processPHPickerImage:(UIImage*)image assetIdentifier:(NSString*)assetIdentifier callbackId:(NSString*)callbackId options:(CDVPictureOptions*)options API_AVAILABLE(ios(14))
1032+
- (void)processPHPickerImage:(UIImage*)image
1033+
assetIdentifier:(NSString*)assetIdentifier
1034+
callbackId:(NSString*)callbackId
1035+
options:(CDVPictureOptions*)options API_AVAILABLE(ios(14))
10331036
{
10341037
__weak CDVCamera* weakSelf = self;
10351038

@@ -1061,7 +1064,10 @@ - (void)processPHPickerImage:(UIImage*)image assetIdentifier:(NSString*)assetIde
10611064
[self finalizePHPickerImage:image metadata:nil callbackId:callbackId options:options];
10621065
}
10631066

1064-
- (void)finalizePHPickerImage:(UIImage*)image metadata:(NSDictionary*)metadata callbackId:(NSString*)callbackId options:(CDVPictureOptions*)options API_AVAILABLE(ios(14))
1067+
- (void)finalizePHPickerImage:(UIImage*)image
1068+
metadata:(NSDictionary*)metadata
1069+
callbackId:(NSString*)callbackId
1070+
options:(CDVPictureOptions*)options API_AVAILABLE(ios(14))
10651071
{
10661072
// Process image according to options
10671073
UIImage *processedImage = image;

0 commit comments

Comments
 (0)