Check import errors only in each mode's Lang-SDK Dag files

The readiness gate and the import-error checks looked at every file of the Dags folder, so a stock example Dag that cannot import in the image (example_event_driven.py without the Kafka provider) would time out the gate and fail the checks in all three Lang-SDK modes. They now check only the mode's own Lang-SDK Dag files.

Author: jason810496

airflow-e2e-tests/tests/airflow_e2e_tests/conftest.py

@@ -1011,6 +1011,12 @@ def airflow_dags_path():
     return _E2ETestState.airflow_dags_path
 
 
+@pytest.fixture(scope="session")
+def lang_sdk_dag_files():
+    """The ``dags-folder`` files of the Lang SDK that the stack was given, in the Lang-SDK modes."""
+    return _E2ETestState.lang_sdk_dag_files
+
+
 @pytest.fixture(scope="session")
 def go_dynamic_dag_ids():
     """The Dag ids that ``go_test_dags.py`` generates from ``E2E_GO_DYNAMIC_DAG_IDS``, in the go_sdk mode."""

airflow-e2e-tests/tests/airflow_e2e_tests/e2e_test_utils/lang_sdk.py

@@ -106,11 +106,12 @@ def get_task_handler_artifacts(compose: DockerCompose) -> dict[ArtifactRef, str]
     return {ArtifactRef(bundle_name, rel_path): probed_at for bundle_name, rel_path, probed_at in rows}
 
 
-def get_import_errors(client: AirflowClient) -> dict[str, str]:
-    """Return the text of the import error of each ``dags-folder`` file that has one, by file."""
+def get_import_errors(client: AirflowClient, files: Collection[str]) -> dict[str, str]:
+    """Return the text of the import error of each of the ``dags-folder`` *files* that has one, by file."""
     return {
         error["filename"]: error["stack_trace"]
         for error in client.list_import_errors(bundle_name=DAGS_BUNDLE_NAME)
+        if error["filename"] in files
     }
 
 
@@ -148,7 +149,8 @@ def wait_until_stub_tasks_are_bound(
 
     :param queues: The queues that the Dag processor routes to a Lang-SDK coordinator.
     :param dag_files: The ``dags-folder`` files of the Lang SDK that the stack was given. Until the Dag
-        processor has parsed them, no stub task is there to be unbound.
+        processor has parsed them, no stub task is there to be unbound. Only their import errors are checked:
+        another file of the Dags folder, such as a stock example Dag, may fail to import for other reasons.
     :param expected_import_errors: The ``dags-folder`` files that fail to import by design.
     :raises TimeoutError: when a Dag file is still not parsed, a stub task is still unbound or an import error
         is still missing or unexpected after *timeout* seconds, with what is missing and the text of the
@@ -159,7 +161,7 @@ def wait_until_stub_tasks_are_bound(
     while True:
         bindings = get_task_handler_bindings(compose)
         unbound = sorted(task for task in get_routed_stub_tasks(client, queues) if task not in bindings)
-        import_errors = get_import_errors(client)
+        import_errors = get_import_errors(client, dag_files)
         missing = sorted(set(expected_import_errors) - set(import_errors))
         unexpected = {
             name: text for name, text in import_errors.items() if name not in expected_import_errors

airflow-e2e-tests/tests/airflow_e2e_tests/go_sdk_tests/test_go_sdk_task_handler_parse.py

@@ -146,7 +146,7 @@ def test_problems_are_one_import_error_of_their_dag_file(client: AirflowClient,
     The error is the one of the file, and lists each problem on a line of its own. Its Dag is serialized but
     marked as having import errors, and none of its stub tasks is bound.
     """
-    assert get_import_errors(client).get(_FAILURE_FILE) == _FAILURE_IMPORT_ERROR
+    assert get_import_errors(client, [_FAILURE_FILE]).get(_FAILURE_FILE) == _FAILURE_IMPORT_ERROR
 
     failing_dags = client.list_dags(bundle_name=DAGS_BUNDLE_NAME, exclude_stale=False, has_import_errors=True)
     assert [dag["dag_id"] for dag in failing_dags] == ["go_task_handler_failures"]
@@ -191,6 +191,6 @@ def test_named_mismatches_are_warnings_in_the_parse_log(airflow_logs_path):
         )
 
 
-def test_only_the_failing_dag_file_has_an_import_error(client: AirflowClient):
-    """No other Dag file of the Dags folder fails to import, so no fixture hides behind the expected error."""
-    assert set(get_import_errors(client)) == {_FAILURE_FILE}
+def test_only_the_failing_dag_file_has_an_import_error(client: AirflowClient, lang_sdk_dag_files):
+    """No other Lang-SDK Dag file fails to import, so no fixture hides behind the expected error."""
+    assert set(get_import_errors(client, lang_sdk_dag_files)) == {_FAILURE_FILE}

airflow-e2e-tests/tests/airflow_e2e_tests/java_sdk_tests/test_java_sdk_task_handler_parse.py

@@ -100,6 +100,6 @@ def test_a_later_parse_probes_nothing(client: AirflowClient, compose_instance, a
     )
 
 
-def test_no_dag_file_has_an_import_error(client: AirflowClient):
-    """Every Dag file of the Dags folder imports: each stub task has exactly one handler that fits it."""
-    assert get_import_errors(client) == {}
+def test_no_dag_file_has_an_import_error(client: AirflowClient, lang_sdk_dag_files):
+    """Every Lang-SDK Dag file imports: each stub task has exactly one handler that fits it."""
+    assert get_import_errors(client, lang_sdk_dag_files) == {}

airflow-e2e-tests/tests/airflow_e2e_tests/ts_sdk_tests/test_ts_sdk_task_handler_parse.py

@@ -74,6 +74,6 @@ def test_a_later_parse_probes_nothing(client: AirflowClient, compose_instance, a
     )
 
 
-def test_no_dag_file_has_an_import_error(client: AirflowClient):
-    """Every Dag file of the Dags folder imports: each stub task has exactly one handler that fits it."""
-    assert get_import_errors(client) == {}
+def test_no_dag_file_has_an_import_error(client: AirflowClient, lang_sdk_dag_files):
+    """Every Lang-SDK Dag file imports: each stub task has exactly one handler that fits it."""
+    assert get_import_errors(client, lang_sdk_dag_files) == {}

contributing-docs/testing/airflow_e2e_tests.rst

@@ -64,8 +64,9 @@ SDK. Run one with ``breeze testing airflow-e2e-tests --e2e-test-mode go_sdk``. E
 toolchain container, or with the host toolchain when ``LANG_SDK_NATIVE_TOOLCHAIN=true`` is set, as CI does.
 
 Before the first test, the tests wait until the Dag processor has bound each stub task on a queue it routes to the
-artifact that registers its task handler, and until the Dag files that fail to import are exactly the ones that are
-meant to. A Dag file with an import error is left out of the binding check. If that does not happen in time, the run
+artifact that registers its task handler, and until the mode's Language SDK Dag files that fail to import are exactly
+the ones that are meant to. Import errors in other files of the Dags folder, such as the stock example Dags, are not
+checked. A Dag file with an import error is left out of the binding check. If that does not happen in time, the run
 fails with the stub tasks that have no binding and the text of any import error nobody expected.
 
 A Dag file that must fail goes in a test bundle, not in a user-facing example, which the tests pin. The Go test