[v3-3-test] Document the 409 from XCom create and drop a duplicated condition (#70992) (#71128)

(cherry picked from commit 64683c9)

Co-authored-by: Jyun-An Chen <jun930436@gmail.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>

Author: 3 people

airflow-core/src/airflow/api_fastapi/core_api/openapi/v2-rest-api-generated.yaml

@@ -6858,6 +6858,12 @@ paths:
               schema:
                 $ref: '#/components/schemas/HTTPExceptionResponse'
           description: Not Found
+        '409':
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/HTTPExceptionResponse'
+          description: Conflict
         '422':
           description: Validation Error
           content:

airflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py

@@ -237,6 +237,7 @@ def get_xcom_entries(
         [
             status.HTTP_400_BAD_REQUEST,
             status.HTTP_404_NOT_FOUND,
+            status.HTTP_409_CONFLICT,
         ]
     ),
     dependencies=[
@@ -269,10 +270,9 @@ def create_xcom_entry(
 
     # Validate Dag Run ID
     if not dag_run:
-        if not dag_run:
-            raise HTTPException(
-                status.HTTP_404_NOT_FOUND, f"Dag Run with ID: `{dag_run_id}` not found for dag: `{dag_id}`"
-            )
+        raise HTTPException(
+            status.HTTP_404_NOT_FOUND, f"Dag Run with ID: `{dag_run_id}` not found for dag: `{dag_id}`"
+        )
 
     # Check existing XCom
     already_existing_query = XComModel.get_many(

airflow-core/src/airflow/ui/openapi-gen/requests/services.gen.ts

@@ -4140,6 +4140,7 @@ export class XcomService {
                 401: 'Unauthorized',
                 403: 'Forbidden',
                 404: 'Not Found',
+                409: 'Conflict',
                 422: 'Validation Error'
             }
         });

airflow-core/src/airflow/ui/openapi-gen/requests/types.gen.ts

@@ -7757,6 +7757,10 @@ export type $OpenApiTs = {
                  * Not Found
                  */
                 404: HTTPExceptionResponse;
+                /**
+                 * Conflict
+                 */
+                409: HTTPExceptionResponse;
                 /**
                  * Validation Error
                  */