Skip to content

Commit bfa9106

Browse files
committed
fixup! Show current task executions in the UI
The Execution tab had its own clear dialog, and the ordinary clear dialog only reached it by delegating when it was handed a single task instance whose in_loop flag was set. Any other path to a loop member, such as the Task Instances bulk action, cleared it by task id and map index, which cannot say which loop pass is meant, and offered none of the loop options. There were therefore two clear dialogs that could disagree. ClearTaskInstanceDialog is now the only one. It accepts a single task instance, every mapped instance of a task, or a selection that may span runs and Dags. When any selected instance is a loop member it addresses the selection by execution id, shows the later-iterations and whole-expansion options next to the usual ones, and does not send past or future, which the API rejects together with exact ids. Otherwise it sends the ordinary task id and map index request. The preview, note, run-on-latest-version, prevent-running and keep-state handling is shared, and the running-task gate dry-runs exactly the request it is about to send. The loop options are not combined with unticking rows from the preview, because the server expands later iterations and whole expansions and an explicit id list cannot express that. The Execution tab works out loop membership from its region data, since its rows carry no in_loop flag, and opens the unified dialog. The Task Instances bulk button renders the same dialog instead of its own modal, so the bulk-only dry-run and clear hooks are removed. A small multi-request dry-run hook merges the previews of a cross-run selection, and ClearExecutionDialog and its now-unused translation key are deleted.
1 parent ae7dfd4 commit bfa9106

13 files changed

Lines changed: 768 additions & 1210 deletions

‎airflow-core/src/airflow/ui/public/i18n/locales/en/dag.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@
6969
"upcomingCount_other": "{{count}} Upcoming Deadlines"
7070
},
7171
"execution": {
72-
"clearDownstream": "Clear downstream tasks",
7372
"clearLater": "Clear later loop iterations",
7473
"clearSelected": "Clear selected executions",
7574
"clearWhole": "Clear whole mapped expansions",

0 commit comments

Comments
 (0)