Skip to content

Commit 5e4c9c7

Browse files
jason810496claude
andcommitted
Make session keyword-only in the task handler model test helpers
airflow-core takes session keyword-only so that it can never be passed in the wrong position, and review flagged the new test helpers for taking it positionally. Co-Authored-By: Claude <noreply@anthropic.com>
1 parent f31dc16 commit 5e4c9c7

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

‎airflow-core/tests/unit/models/test_lang_sdk_task_handler.py‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def _make_handler(*, dag_id: str, artifact: LangSDKTaskHandlerArtifact) -> LangS
6060
)
6161

6262

63-
def _add_dags_and_artifact(session, *dag_ids: str) -> LangSDKTaskHandlerArtifact:
63+
def _add_dags_and_artifact(*dag_ids: str, session) -> LangSDKTaskHandlerArtifact:
6464
session.add_all(DagModel(dag_id=dag_id, bundle_name="testing") for dag_id in dag_ids)
6565
artifact = _make_artifact()
6666
session.add(artifact)
@@ -69,7 +69,7 @@ def _add_dags_and_artifact(session, *dag_ids: str) -> LangSDKTaskHandlerArtifact
6969

7070

7171
def test_deleting_dag_deletes_its_handlers(testing_dag_bundle, session):
72-
artifact = _add_dags_and_artifact(session, "dag_a", "dag_b")
72+
artifact = _add_dags_and_artifact("dag_a", "dag_b", session=session)
7373
session.add_all(_make_handler(dag_id=dag_id, artifact=artifact) for dag_id in ("dag_a", "dag_b"))
7474
session.flush()
7575

@@ -80,7 +80,7 @@ def test_deleting_dag_deletes_its_handlers(testing_dag_bundle, session):
8080

8181

8282
def test_handler_stores_its_declaration(testing_dag_bundle, session):
83-
artifact = _add_dags_and_artifact(session, "dag_a")
83+
artifact = _add_dags_and_artifact("dag_a", session=session)
8484
session.add(_make_handler(dag_id="dag_a", artifact=artifact))
8585
session.flush()
8686
session.expire_all()
@@ -93,7 +93,7 @@ def test_handler_stores_its_declaration(testing_dag_bundle, session):
9393

9494

9595
def test_deleting_referenced_artifact_fails(testing_dag_bundle, session):
96-
artifact = _add_dags_and_artifact(session, "dag_a")
96+
artifact = _add_dags_and_artifact("dag_a", session=session)
9797
session.add(_make_handler(dag_id="dag_a", artifact=artifact))
9898
session.flush()
9999

@@ -158,15 +158,15 @@ def test_core_insert_fills_fileloc_hashes(testing_dag_bundle, session):
158158
)
159159

160160

161-
def _add_artifact(session) -> LangSDKTaskHandlerArtifact:
161+
def _add_artifact(*, session) -> LangSDKTaskHandlerArtifact:
162162
artifact = _make_artifact()
163163
session.add(artifact)
164164
session.flush()
165165
return artifact
166166

167167

168-
def _add_handler(session) -> LangSDKTaskHandler:
169-
handler = _make_handler(dag_id="dag_a", artifact=_add_dags_and_artifact(session, "dag_a"))
168+
def _add_handler(*, session) -> LangSDKTaskHandler:
169+
handler = _make_handler(dag_id="dag_a", artifact=_add_dags_and_artifact("dag_a", session=session))
170170
session.add(handler)
171171
session.flush()
172172
return handler
@@ -196,7 +196,7 @@ def _add_handler(session) -> LangSDKTaskHandler:
196196
def test_fileloc_hash_follows_orm_updates(
197197
testing_dag_bundle, session, add_row, path_attr, hash_column, other_attr, other_value
198198
):
199-
row = add_row(session)
199+
row = add_row(session=session)
200200
original_path = getattr(row, path_attr)
201201

202202
setattr(row, other_attr, other_value)

0 commit comments

Comments
 (0)