Share the bundle section mutation helper between Node tests

Author: jason810496

task-sdk/tests/task_sdk/coordinators/node/_bundle_test_utils.py

@@ -142,3 +142,8 @@ def mutate_byte(bundle: pathlib.Path, offset: int) -> None:
     contents = bytearray(bundle.read_bytes())
     contents[offset] = ord("A") if contents[offset] != ord("A") else ord("B")
     bundle.write_bytes(contents)
+
+
+def mutate_section(bundle: pathlib.Path, section: str) -> None:
+    """Change the first byte of a layout section, so its digest no longer matches."""
+    mutate_byte(bundle, int(read_layout(bundle)[section]["start"], 16))  # type: ignore[index, call-overload]

task-sdk/tests/task_sdk/coordinators/node/test_coordinator.py

@@ -27,6 +27,7 @@
 from task_sdk.coordinators.node._bundle_test_utils import (
     BUNDLE_NAME,
     mutate_byte,
+    mutate_section,
     read_layout,
     write_bundle,
 )
@@ -153,7 +154,7 @@ def test_returns_node_and_bundle_schema_version(self, tmp_path):
 
     def test_tampered_bundle_raises(self, tmp_path):
         bundle = write_bundle(tmp_path, "native_dag")
-        mutate_byte(bundle, int(read_layout(bundle)["code"]["start"], 16))  # type: ignore[index, call-overload]
+        mutate_section(bundle, "code")
 
         with pytest.raises(ValueError, match="code SHA-256 mismatch"):
             NodeCoordinator()._build_parse_dag_command(path=bundle)

task-sdk/tests/task_sdk/coordinators/node/test_dag_importer.py

@@ -24,8 +24,7 @@
 from task_sdk.coordinators.node._bundle_test_utils import (
     BUNDLE_NAME,
     LAYOUT_PREFIX,
-    mutate_byte,
-    read_layout,
+    mutate_section,
     write_bundle,
 )
 
@@ -45,14 +44,10 @@ def importer() -> NodeDagImporter:
     return NodeDagImporter(coordinator=NodeCoordinator())
 
 
-def _mutate_section(bundle: pathlib.Path, section: str) -> None:
-    mutate_byte(bundle, int(read_layout(bundle)[section]["start"], 16))  # type: ignore[index, call-overload]
-
-
 def test_lists_only_packed_bundles(importer, tmp_path):
     nested = write_bundle(tmp_path / "team", "sales")
     tampered = write_bundle(tmp_path, "inventory", name="tampered.min.mjs")
-    _mutate_section(tampered, "code")
+    mutate_section(tampered, "code")
     write_bundle(tmp_path, "orders", name="plain.mjs")
     (tmp_path / "vendor.min.mjs").write_bytes(b"export {};\n")
 
@@ -105,7 +100,7 @@ def test_returns_the_entry_module(self, importer, tmp_path):
     @pytest.mark.parametrize(
         ("break_bundle", "reason"),
         [
-            (lambda path: _mutate_section(path, "source"), "source SHA-256 mismatch"),
+            (lambda path: mutate_section(path, "source"), "source SHA-256 mismatch"),
             (lambda path: write_bundle(path.parent, "sales", source=b"x" * (1024 * 1024 + 1)), "exceeds"),
             (lambda path: path.unlink(), "cannot read bundle.min.mjs"),
         ],