utils: rename generated 'version' file to 'thapi_version' (avoid shadowing C++ <version>)

Author: Romain PEREIRA

utils/Makefile.am

@@ -50,17 +50,20 @@ bin_SCRIPTS = \
 noinst_SCRIPTS = \
 	test_wrapper_thapi_text_pretty.sh
 
-.PHONY: version
+.PHONY: thapi_version
 
-version:
-	git describe --abbrev=7 --dirty --always --tags > version || echo $(PACKAGE_VERSION) > version
+# Must NOT be named `version`: utils/ is on the C++ include path and a file
+# named `version` shadows the standard <version> header (used by libstdc++/
+# abseil/protobuf), which breaks the xprof build.
+thapi_version:
+	git describe --abbrev=7 --dirty --always --tags > thapi_version || echo $(PACKAGE_VERSION) > thapi_version
 
 data_DATA = \
-	version \
+	thapi_version \
 	optparse_thapi.rb
 
 CLEANFILES = \
-	version \
+	thapi_version \
 	optparse_thapi.rb \
 	lttng/tracepoint_gen.h \
 	$(BUILT_SOURCES)

utils/babeltrace_thapi.in

@@ -401,7 +401,7 @@ class BabeltraceParserThapi < OptionParserWithDefaultAndValidation
     on('--archive-session-found-file-path PATH')
     on('--[no-]muxer')
     on('-v', '--version', 'Print the version string') do
-      puts File.read(File.join(DATADIR, 'version'))
+      puts File.read(File.join(DATADIR, 'thapi_version'))
       exit
     end
   end

xprof/xprof.rb.in

@@ -1122,7 +1122,7 @@ if $thapi_launch || __FILE__ == $PROGRAM_NAME
 
   parser.on('--metadata', 'Display trace metadata.')
   parser.on('-v', '--version', 'Print the Version String.') do
-    puts File.read(File.join(DATADIR, 'version'))
+    puts File.read(File.join(DATADIR, 'thapi_version'))
     exit
   end
   parser.on('-h', '--help', 'Display this message.') { print_help_and_exit(parser, exit_code: 0) }