-
Notifications
You must be signed in to change notification settings - Fork 39
Open
Description
Hi, I use the library in my streaming app and I encountered a potential issue, at some point very rarely my app was crashing so I started to investigating this problem and I found out it crashes here
because the output variable was 'none' and the reason is that sample count returned 0 before ->
let sampleCount = opus_decoder_get_nb_samples(decoder, input.baseAddress!, Int32($0.count))
There was a pull request which added a check for this
But this check should it not rather be
if sampleCount < 1 {
throw Opus.Error(sampleCount)
}
as otherwise there will be a crash?
Metadata
Metadata
Assignees
Labels
No labels