Repository navigation
Commit 02eced0
committed
fix(tools): honor machine-bundle protect paths in the in-process edit tools
_refuse_protected_writes guarded only .git; apply_edit/apply_patch write
in-process (outside the jail), so a mode='run' machine state could rewrite its
own .asm.toml or scripts/ -- persisting a payload for the next run -- even
though the jail marks the bundle read-only for run_command. Refuse an
in-process write whose resolved path is at or under any extra_protect_path, on
both sandbox profiles.
Security review note: the in-process edit tools now enforce the operator/machine
protect-path set, not just .git. The docs/security.md bundle-confinement claim
is still partly inaccurate for the hardened jail's nested run_command case (a
separate main.rs item); correct the doc together with that fix.1 parent c0a0741 commit 02eced0
2 files changed
Lines changed: 58 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
730 | 730 | | |
731 | 731 | | |
732 | 732 | | |
733 | | - | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
734 | 739 | | |
735 | 740 | | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
736 | 749 | | |
737 | 750 | | |
738 | 751 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
301 | 301 | | |
302 | 302 | | |
303 | 303 | | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
304 | 348 | | |
305 | 349 | | |
306 | 350 | | |
| |||
0 commit comments