Generic AddJsonFile<TProvider>(configure:) registers configure on Options.DefaultName — unfixed half of #22

[gerritgoetzen]

The v3.3.1 fix for #22 was incomplete. #22 reported two defects in the generic AddJsonFile<TProvider>: (a) ConfigureTextBuilder ignoring optionsName, and (b) the user configure callback being registered against Options.DefaultName instead of the provider's named-options instance. The fix (commit fe6a9fe) addressed (a) only; (b) is still present in v4.1.0.

Where: source/FileLogger.Json/JsonFileLoggerExtensions.cs. Every generic overload (<TProvider>, <TProvider,TOptions>, and the bindOptions variant) calls builder.AddFile<…>(context, configure: null, optionsName) and then builder.Services.Configure(configure) — unnamed, so it binds to Options.DefaultName. The provider reads its options under optionsName ?? typeof(TProvider).ToString(), so the configure callback never reaches it. Within a single call, TextBuilder lands on the named instance while the user's configure lands on DefaultName.

Scope: this fires whenever configure is supplied — an explicit optionsName is not required, since the provider reads under typeof(TProvider).ToString(), never DefaultName.

Contrast: the sibling AddFile<TProvider> in FileLoggerFactoryExtensions.cs is correct — builder.Services.Configure(optionsName, configure).

Repro:

loggingBuilder.AddJsonFile<MyFileLoggerProvider>(
    optionsName: "MyJson",
    configure: o => o.RootPath = AppContext.BaseDirectory);

The resulting provider does not see RootPath — it reads options "MyJson", but configure was applied to "".

Suggested fix: forward configure into AddFile<TProvider>(context, configure, optionsName), which already names it, and drop the trailing unnamed Services.Configure. Equivalent: builder.Services.Configure(optionsName ?? typeof(TProvider).ToString(), configure).

Workaround (per #22): omit configure: and call Services.Configure<FileLoggerOptions>(optionsName, …) separately.

Version: 4.1.0. Related: #22 (original report, closed as fixed in v3.3.1).

[adams85]

Nice catch! Indeed, optionsName is incorrectly not passed to builder.Services.Configure(...) calls in those generic overloads.

I've created a PR fixing this.

Let me know if this looks good, or if you see any other issues.

[gerritgoetzen]

Thanks for the quick fix — #40 looks correct to me. It forwards optionsName to Services.Configure(...) in all three generic overloads, which is exactly the missing half from #22 and matches the sibling AddFile.

I've opened #41 with regression tests covering all three overloads (they fail against the pre-fix source and pass with #40). It's currently stacked on #40, so it shows two commits until #40 lands on master; happy to rebase it down to just the test commit afterwards, or you're welcome to fold the test directly into #40 — whichever is easiest for you.

No other issues spotted.

[adams85]

The fix is released in v4.1.1 and is now available on NuGet.

[gerritgoetzen]

Package updated to v4.1.1 in my app and workaround removed. Works as expected. Thanks for the quick release.