Skip to content

Commit f798cdd

Browse files
authored
docs: use INSTALLATION_NAME (#2552)
Signed-off-by: kahirokunn <[email protected]>
1 parent 367ee46 commit f798cdd

File tree

1 file changed

+15
-16
lines changed
  • docs/preview/gha-runner-scale-set-controller

1 file changed

+15
-16
lines changed

docs/preview/gha-runner-scale-set-controller/README.md

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ In addition to the increased reliability of the automatic scaling, we have worke
6868
GITHUB_APP_ID="<GITHUB_APP_ID>"
6969
GITHUB_APP_INSTALLATION_ID="<GITHUB_APP_INSTALLATION_ID>"
7070
GITHUB_APP_PRIVATE_KEY="<GITHUB_APP_PRIVATE_KEY>"
71-
helm install arc-runner-set \
71+
helm install "${INSTALLATION_NAME}" \
7272
--namespace "${NAMESPACE}" \
7373
--create-namespace \
7474
--set githubConfigUrl="${GITHUB_CONFIG_URL}" \
@@ -101,13 +101,12 @@ In addition to the increased reliability of the automatic scaling, we have worke
101101
```yaml
102102
name: Test workflow
103103
on:
104-
workflow_dispatch:
105-
104+
workflow_dispatch:
106105
jobs:
107-
test:
106+
test:
108107
runs-on: arc-runner-set
109-
steps:
110-
- name: Hello world
108+
steps:
109+
- name: Hello world
111110
run: echo "Hello world"
112111
```
113112

@@ -209,10 +208,10 @@ To fix this, you can either:
209208
210209
```yaml
211210
spec:
212-
securityContext:
213-
fsGroup: 123
214-
containers:
215-
- name: runner
211+
securityContext:
212+
fsGroup: 123
213+
containers:
214+
- name: runner
216215
image: ghcr.io/actions/actions-runner:<VERSION> # Replace <VERSION> with the version you want to use
217216
command: ["/home/runner/run.sh"]
218217
```
@@ -222,15 +221,15 @@ To fix this, you can either:
222221
```yaml
223222
template:
224223
spec:
225-
initContainers:
226-
- name: kube-init
224+
initContainers:
225+
- name: kube-init
227226
image: ghcr.io/actions/actions-runner:latest
228227
command: ["sudo", "chown", "-R", "1001:123", "/home/runner/_work"]
229228
volumeMounts:
230-
- name: work
231-
mountPath: /home/runner/_work
232-
containers:
233-
- name: runner
229+
- name: work
230+
mountPath: /home/runner/_work
231+
containers:
232+
- name: runner
234233
image: ghcr.io/actions/actions-runner:latest
235234
command: ["/home/runner/run.sh"]
236235
```

0 commit comments

Comments
 (0)