Skip to content

Clear styles for dApp layout  #893

@kkosiorowska

Description

@kkosiorowska

During work on #892, I noticed that the change padding needed to be made in 3 places to keep the layout consistent. Padding should be set once to make it easier to manage layout styles. Additionally, the header and footer have the same value for maxW, a possible change also requires updating the two styles in completely different places.

https://github.com/thesis/acre/blob/51788f66e211c8e5008c97b752b672e3cbd46bee/dapp/src/components/Layout.tsx#L36

https://github.com/thesis/acre/blob/51788f66e211c8e5008c97b752b672e3cbd46bee/dapp/src/components/Header/index.tsx#L12-L18

https://github.com/thesis/acre/blob/51788f66e211c8e5008c97b752b672e3cbd46bee/dapp/src/theme/Footer.ts#L20-L22

Let's update the Layout component and simplify the styles for Header, Footer and main content.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions