Fix tests; drop bin composer (not used by CI, complex)

Author: MonsieurV

.github/workflows/ci.yml

@@ -64,7 +64,8 @@ jobs:
           
           # Remove dependencies we don't need for unit tests that break platform requirements
           composer remove --dev \
-            bamarni/composer-bin-plugin
+            friendsofphp/php-cs-fixer \
+            kubawerlos/php-cs-fixer-custom-fixers
 
           composer install
 

.github/workflows/linting.yml

@@ -12,10 +12,10 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v3
 
-      - name: Set up PHP 8.4
+      - name: Set up PHP 8.3
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '8.4'
+          php-version: '8.3'
           extensions: mbstring
 
       - name: Get Composer Cache Directory
@@ -26,8 +26,8 @@ jobs:
         uses: actions/cache@v3
         with:
           path: ${{ steps.composer-cache.outputs.dir }}
-          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
-          restore-keys: ${{ runner.os }}-composer-
+          key: ${{ runner.os }}-composer-lint-${{ hashFiles('**/composer.lock') }}
+          restore-keys: ${{ runner.os }}-composer-lint-
 
       - name: Install dependencies
         run: composer install
@@ -45,10 +45,10 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v3
 
-      - name: Set up PHP 8.4
+      - name: Set up PHP 8.3
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '8.4'
+          php-version: '8.3'
           extensions: mbstring
 
       - name: Get Composer Cache Directory
@@ -59,8 +59,8 @@ jobs:
         uses: actions/cache@v3
         with:
           path: ${{ steps.composer-cache.outputs.dir }}
-          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
-          restore-keys: ${{ runner.os }}-composer-
+          key: ${{ runner.os }}-composer-lint-${{ hashFiles('**/composer.lock') }}
+          restore-keys: ${{ runner.os }}-composer-lint-
 
       - name: Install dependencies
         run: composer install

CONTRIBUTING.md

@@ -34,7 +34,7 @@ Also useful:
 - Always add tests for the code that you write, including edge cases ;
 - Place the new functions where they belong (collections, arrays, utilities, etc.) ;
 - Add `README.md` doc entry for the functions ;
-- Execute `php composer.phar run doc` script to automatically build an updated `load.php` ;
+- Execute `composer run doc` script to automatically build an updated `load.php` ;
 - Update the benchmark `bench.php`, this helps us to validate the performance of the library ;
 - Update `CHANGELOG.md` with your changes.
 

composer.json

@@ -17,13 +17,13 @@
     "require-dev": {
         "php": ">=8.1",
         "ext-json": "*",
-        "bamarni/composer-bin-plugin": "^1.8",
         "doctrine/instantiator": "^1.0||^1.1||^1.4",
         "erusev/parsedown": "^1.7",
         "friendsofphp/php-cs-fixer": "^3.68",
         "nikic/php-parser": "^3.1||^4.13",
         "phpdocumentor/reflection-docblock": "^3.0||^4.3||^5.2",
-        "phpunit/phpunit": "^4.8||^6.5||^9.5"
+        "phpunit/phpunit": "^4.8||^6.5||^9.5",
+        "kubawerlos/php-cs-fixer-custom-fixers": "^3.14"
     },
     "autoload": {
         "classmap": ["bottomline.php"],