In processResult ErrorResponseException is never thrown if there is a Guzzle Exception

[tm1000]

See: https://github.com/Weble/ZohoBooksApi/blob/develop/src/Client.php#L218

If there are errors from upstream Zoho (like 400) then the Guzzle Exception is thrown instead of ErrorResponseException. Perhaps this is intentional but this was not the case in previous versions, and thus if it is intentional then ErrorResponseException should not say it is the base class for all Exceptions

[Skullbock]

Hi! You're basically saying that here:

https://github.com/Weble/ZohoBooksApi/blob/develop/src/Client.php#L197

We should do

throw new ErrorResponseException($e->getCode(), $e->getMessage(), $e);

instead of throw $e right?

Can you send a PR in for that?

[Skullbock]

@tm1000 where you able to fix this in the end?

[tm1000]

@Skullbock I'll spend some time working on this during my development (as im using all of your libraries exclusively now)

[Skullbock]

Thanks @tm1000 glad to hear that