Trim the result of URLs in "href". (#302)

philipp-classen · web-flow · commit 257ae3ae147a · 2025-04-28T08:25:26.000+02:00
* Trim the result of URLs in "href". fixes #301 * Fix CI
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -15,9 +15,9 @@ jobs:
         node-version: [20]
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v2
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node-version }}
         cache: 'npm'
diff --git a/cjs/html/anchor-element.js b/cjs/html/anchor-element.js
@@ -15,7 +15,7 @@ class HTMLAnchorElement extends HTMLElement {
   }
 
   /* c8 ignore start */ // copy paste from img.src, already covered
-  get href() { return encodeURI(decodeURI(stringAttribute.get(this, 'href'))); }
+  get href() { return encodeURI(decodeURI(stringAttribute.get(this, 'href'))).trim(); }
   set href(value) { stringAttribute.set(this, 'href', decodeURI(value)); }
 
   get download() { return encodeURI(decodeURI(stringAttribute.get(this, 'download'))); }
diff --git a/cjs/html/link-element.js b/cjs/html/link-element.js
@@ -18,7 +18,7 @@ class HTMLLinkElement extends HTMLElement {
   get disabled() { return booleanAttribute.get(this, 'disabled'); }
   set disabled(value) { booleanAttribute.set(this, 'disabled', value); }
 
-  get href() { return stringAttribute.get(this, 'href'); }
+  get href() { return stringAttribute.get(this, 'href').trim(); }
   set href(value) { stringAttribute.set(this, 'href', value); }
 
   get hreflang() { return stringAttribute.get(this, 'hreflang'); }
diff --git a/esm/html/anchor-element.js b/esm/html/anchor-element.js
@@ -14,7 +14,7 @@ class HTMLAnchorElement extends HTMLElement {
   }
 
   /* c8 ignore start */ // copy paste from img.src, already covered
-  get href() { return encodeURI(decodeURI(stringAttribute.get(this, 'href'))); }
+  get href() { return encodeURI(decodeURI(stringAttribute.get(this, 'href'))).trim(); }
   set href(value) { stringAttribute.set(this, 'href', decodeURI(value)); }
 
   get download() { return encodeURI(decodeURI(stringAttribute.get(this, 'download'))); }
diff --git a/esm/html/link-element.js b/esm/html/link-element.js
@@ -17,7 +17,7 @@ class HTMLLinkElement extends HTMLElement {
   get disabled() { return booleanAttribute.get(this, 'disabled'); }
   set disabled(value) { booleanAttribute.set(this, 'disabled', value); }
 
-  get href() { return stringAttribute.get(this, 'href'); }
+  get href() { return stringAttribute.get(this, 'href').trim(); }
   set href(value) { stringAttribute.set(this, 'href', value); }
 
   get hreflang() { return stringAttribute.get(this, 'hreflang'); }
diff --git a/test/html/anchor-element.js b/test/html/anchor-element.js
@@ -13,3 +13,9 @@ a.setAttribute('href', 'https://google.com/?q=asd&lol=<2>"');
 assert(a.href, 'https://google.com/?q=asd&lol=%3C2%3E%22');
 a.setAttribute('href', 'https://google.com/path%20to%20some%20file.pdf');
 assert(a.href, 'https://google.com/path%20to%20some%20file.pdf');
+
+// "href" should trim links, but getAttribute should preserve the original value
+const untrimmedLink = '                https://example.com/\n         ';
+const hrefExample = parseHTML( `<!DOCTYPE html><html><head><title>Test</title><link rel='canonical' href="${untrimmedLink}"></head><body></body></html>`, 'text/html').document.querySelector('link');
+assert(hrefExample.href, 'https://example.com/');
+assert(hrefExample.getAttribute('href'), untrimmedLink);
diff --git a/worker.js b/worker.js
@@ -11575,7 +11575,7 @@ class HTMLLinkElement extends HTMLElement {
   get disabled() { return booleanAttribute.get(this, 'disabled'); }
   set disabled(value) { booleanAttribute.set(this, 'disabled', value); }
 
-  get href() { return stringAttribute.get(this, 'href'); }
+  get href() { return stringAttribute.get(this, 'href').trim(); }
   set href(value) { stringAttribute.set(this, 'href', value); }
 
   get hreflang() { return stringAttribute.get(this, 'hreflang'); }
@@ -11792,7 +11792,7 @@ class HTMLAnchorElement extends HTMLElement {
   }
 
   /* c8 ignore start */ // copy paste from img.src, already covered
-  get href() { return encodeURI(decodeURI(stringAttribute.get(this, 'href'))); }
+  get href() { return encodeURI(decodeURI(stringAttribute.get(this, 'href'))).trim(); }
   set href(value) { stringAttribute.set(this, 'href', decodeURI(value)); }
 
   get download() { return encodeURI(decodeURI(stringAttribute.get(this, 'download'))); }

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ class HTMLAnchorElement extends HTMLElement {`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`/* c8 ignore start */ // copy paste from img.src, already covered`
`18`		`- get href() { return encodeURI(decodeURI(stringAttribute.get(this, 'href'))); }`
	`18`	`+ get href() { return encodeURI(decodeURI(stringAttribute.get(this, 'href'))).trim(); }`
`19`	`19`	`set href(value) { stringAttribute.set(this, 'href', decodeURI(value)); }`
`20`	`20`
`21`	`21`	`get download() { return encodeURI(decodeURI(stringAttribute.get(this, 'download'))); }`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ class HTMLAnchorElement extends HTMLElement {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`/* c8 ignore start */ // copy paste from img.src, already covered`
`17`		`- get href() { return encodeURI(decodeURI(stringAttribute.get(this, 'href'))); }`
	`17`	`+ get href() { return encodeURI(decodeURI(stringAttribute.get(this, 'href'))).trim(); }`
`18`	`18`	`set href(value) { stringAttribute.set(this, 'href', decodeURI(value)); }`
`19`	`19`
`20`	`20`	`get download() { return encodeURI(decodeURI(stringAttribute.get(this, 'download'))); }`