feat: add get_some_shortest_word#627
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #627 +/- ##
==========================================
+ Coverage 72.91% 72.93% +0.02%
==========================================
Files 45 45
Lines 6796 7256 +460
Branches 1538 1634 +96
==========================================
+ Hits 4955 5292 +337
- Misses 1227 1323 +96
- Partials 614 641 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adda0
reviewed
Jun 1, 2026
| std::optional<Word> get_word(std::optional<Symbol> first_epsilon = EPSILON) const; | ||
|
|
||
| /// Returns one of the shortest words of @p aut | ||
| std::optional<mata::Word> get_some_shortest_word(const mata::nfa::Nfa& aut); |
Collaborator
There was a problem hiding this comment.
I would rename it for easier discovery to something like get_shortest_word. The some will only hide the function when looking for get_shortest.
Member
There was a problem hiding this comment.
Hmm, yeah, that is good idea, @m-vallus, can you rename it?
Adda0
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.