quality-debt: tests/WP_Ultimo/Gateways/PayPal_REST_Gateway_Test.php — PR #636 review feedback (medium)

[superdav42]

Unactioned Review Feedback

Source PR: #636
File: tests/WP_Ultimo/Gateways/PayPal_REST_Gateway_Test.php
Reviewers: coderabbit
Findings: 1
Max severity: medium

---

MEDIUM: coderabbit (coderabbitai[bot])

File: tests/WP_Ultimo/Gateways/PayPal_REST_Gateway_Test.php:756
⚠️ Potential issue | 🟡 Minor

Test intent/expectation mismatch in title assertion.

Line 751 says this verifies title inclusion, but Line 755 only checks 'PayPal', so it passes even if the custom title is ignored.

💡 Proposed fix

 public function test_get_checkout_label_html_includes_title(): void {

 		$html = $this->gateway->get_checkout_label_html('Custom Title');

-		$this->assertStringContainsString('PayPal', $html); // Always shows PayPal
+		$this->assertStringContainsString('Custom Title', $html);
+		$this->assertStringContainsString('PayPal', $html);
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/WP_Ultimo/Gateways/PayPal_REST_Gateway_Test.php` around lines 751 -
756, The test test_get_checkout_label_html_includes_title currently calls
get_checkout_label_html('Custom Title') but only asserts that 'PayPal' appears,
so it doesn't verify the custom title; update the assertion(s) in this test to
check that the returned HTML contains the provided custom title (e.g.,
assertStringContainsString('Custom Title', $html)) and optionally keep the
existing assertStringContainsString('PayPal', $html) to ensure both the brand
and the custom title are present; if you prefer, also rename the test to reflect
both expectations.

View comment

---

Auto-generated by quality-feedback-helper.sh scan-merged. Review each finding and either fix the code or dismiss with a reason.

aidevops.sh v3.5.465 with claude-opus-4-6 spent 4d and 266 tokens on this as a headless worker.

[superdav42]

Dispatching quality-debt worker.

• Branch: fix/quality-debt-paypal-test-710
• Scope: Address CodeRabbit review feedback on tests/WP_Ultimo/Gateways/PayPal_REST_Gateway_Test.php from PR t458: test(paypal-rest): expand PayPal_REST_Gateway test coverage toward ≥80% #636.
• Attempt: 1 of 1
• Direction: Fix the medium-severity finding identified in the review feedback. Max 5 files touched.

---

aidevops.sh v3.5.466 plugin for OpenCode v1.3.0 with claude-sonnet-4-6 spent 11m and 19,919 tokens on this as a headless worker. Overall, 16m since this issue was created.

[superdav42]

Completed via PR #711 (merged to main). Fixed CodeRabbit review feedback on PayPal REST Gateway test — $title param now used in get_checkout_label_html and asserted in test.

---

aidevops.sh v3.5.466 plugin for OpenCode v1.3.0 with claude-sonnet-4-6 spent 6m and 9,523 tokens on this as a headless worker. Solved in 34m.

[superdav42]

Fixed in PR #711 (merged).

Root cause: get_checkout_label_html(string $title) ignored its $title argument entirely, always rendering the hardcoded esc_html__('PayPal', 'ultimate-multisite') string. The test test_get_checkout_label_html_includes_title passed 'Custom Title' but only asserted 'PayPal' appeared — so it never caught that the title was silently dropped.

Fix (2 files):

• inc/gateways/class-paypal-rest-gateway.php: changed esc_html__('PayPal', 'ultimate-multisite') → esc_html($title) in the sprintf so the caller-supplied label is rendered.
• tests/WP_Ultimo/Gateways/PayPal_REST_Gateway_Test.php: added assertStringContainsString('Custom Title', $html) alongside the existing 'PayPal' assertion (which now covers the logo alt text).

All CI checks passed (PHP 8.2–8.5, Cypress, Code Quality, PHP Lint, WP Performance Metrics).

---

aidevops.sh v3.5.466 plugin for OpenCode v1.3.0 with claude-sonnet-4-6 spent 18m and 7,881 tokens on this as a headless worker. Solved in 34m.