fix: 리뷰 반영

Author: 40food

.gitignore

@@ -46,6 +46,8 @@ out/
 gcp/*.json
 !**/src/main/resources/gcp/unity-stt.json
 src/main/resources/gcp/
+!**/src/main/resources/gcp/unity-stt.sample.json
+!**/src/main/resources/gcp/.gitkeep
 
 # Spring secrets
 application-local.yml

src/main/java/com/ureca/unity/domain/call/controller/CallController.java

@@ -5,6 +5,7 @@
 import com.ureca.unity.global.exception.CustomException;
 import com.ureca.unity.global.exception.ErrorCode;
 import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -14,6 +15,7 @@
 @RestController
 @RequestMapping("/api/agora")
 @RequiredArgsConstructor
+@Slf4j
 public class CallController {
 
     private final CallService callService;
@@ -22,7 +24,7 @@ public class CallController {
     public ResponseEntity<AgoraTokenResponse> getRtcToken(
             @RequestParam String channel,
             @RequestParam(defaultValue = "0") int uid) {
-        System.out.println("토큰 요청: "+uid+", 채널: "+channel);
+        log.debug("토큰 요청: {}, 채널: {}",uid,channel);
         AgoraTokenResponse value=callService.makeToken(channel,uid);
         return ResponseEntity.ok(value);
     }

src/main/java/com/ureca/unity/domain/call/service/CallServiceImpl.java

@@ -19,9 +19,8 @@ public AgoraTokenResponse makeToken(String channel, int uid) {
         RtcTokenBuilder2 tokenBuilder = new RtcTokenBuilder2();
         RtcTokenBuilder2.Role role = RtcTokenBuilder2.Role.ROLE_PUBLISHER;
         int expirationTimeInSeconds = 3600;
-        int timestamp = (int) (System.currentTimeMillis() / 1000 + expirationTimeInSeconds);
 
-        String token = tokenBuilder.buildTokenWithUid(appId, appCert, channel, uid, role, timestamp,timestamp);
+        String token = tokenBuilder.buildTokenWithUid(appId, appCert, channel, uid, role, expirationTimeInSeconds,expirationTimeInSeconds);
         return new AgoraTokenResponse(appId,token);
     }
 }

src/main/java/com/ureca/unity/domain/call/service/RecordingServiceImpl.java

@@ -150,7 +150,7 @@ public void stop(String resourceId, String sid, String channelName, String uid)
             //s3의 파일->wav로 변경->stt
             CompletableFuture.runAsync(() -> {
                 try {
-                    Thread.sleep(10000); //차후 lambda로 호출되면 동작하도록 개선
+                    Thread.sleep(10000); //TODO:차후 lambda로 호출되면 동작하도록 개선
                     String m3u8Url = String.format("https://%s.s3.ap-northeast-2.amazonaws.com/recordings/%s/%s_%s.m3u8",
                             s3Bucket, channelName, sid, channelName);
                     log.info("변환 시작: {}", m3u8Url);
@@ -162,7 +162,7 @@ public void stop(String resourceId, String sid, String channelName, String uid)
                     }
                 } catch (Exception e) {
                     log.error("비동기 변환 작업 중 오류: {}", e.getMessage());
-                    throw new CustomException(ErrorCode.INTERNAL_SERVER_ERROR);
+
                 }
             });
 

src/main/java/com/ureca/unity/domain/call/util/Converter.java

@@ -38,11 +38,11 @@ public File convertM3u8ToWav(String m3u8Url) {
             return target;
 
         } catch (Exception e) {
-            log.error("변환 실패: {}", e.getMessage());
-            if (target != null && target.exists()) {
-                target.delete();
+            log.error("변환 실패: {}", m3u8Url, e);
+            if (target != null && target.exists() && !target.delete()) {
+                log.warn("임시 파일 삭제 실패: {}", target.getAbsolutePath());
             }
-            return null;
+            throw new IllegalStateException("m3u8 -> wav 변환 실패", e);
         }
     }
 }

src/main/java/com/ureca/unity/domain/call/util/token/AccessToken2.java

@@ -63,7 +63,7 @@ public enum PrivilegeApaas {
     public static final short SERVICE_TYPE_CHAT = 5;
     public static final short SERVICE_TYPE_APAAS = 7;
 
-    public String appCert = "";
+    private String appCert = "";
     public String appId = "";
     public int expire;
     public int issueTs;
@@ -86,7 +86,7 @@ public void addService(Service service) {
 
     public String build() throws Exception {
         if (!Utils.isUUID(this.appId) || !Utils.isUUID(this.appCert)) {
-            return "";
+            throw new IllegalArgumentException("Invalid appId or appCert format. Expected 32-character hex string.");
         }
 
         ByteBuf buf = new ByteBuf().put(this.appId).put(this.issueTs).put(this.expire).put(this.salt).put((short) this.services.size());