fix: address provider selection review

Author: PierrunoYT

internal/cli/command_center.go

@@ -419,7 +419,7 @@ func formatProviderCLILine(provider providerCLISummary) string {
 	}
 	line := fmt.Sprintf("%s %s [%s] model=%s apiModel=%s api key: %s", marker, displayCLIValue(provider.Name, "none"), displayCLIValue(provider.ProviderKind, "unknown"), displayCLIValue(provider.Model, "none"), displayCLIValue(provider.APIModel, "unknown"), providerCredentialState(provider.providerSummary))
 	if !provider.Selectable {
-		line += " (runtime-only; not selectable/saved)"
+		line += " (not selectable via providers use)"
 	}
 	if provider.Message != "" {
 		line += " (" + provider.Status + ": " + provider.Message + ")"

internal/cli/command_center_test.go

@@ -220,11 +220,12 @@ func TestRunProvidersListMarksUserAndRuntimeProfiles(t *testing.T) {
 	}
 
 	stdout.Reset()
+	stderr.Reset()
 	if code := runWithDeps([]string{"providers", "list"}, &stdout, &stderr, deps); code != exitSuccess {
 		t.Fatalf("code=%d stderr=%s", code, stderr.String())
 	}
-	if !strings.Contains(stdout.String(), "runtime-only; not selectable/saved") {
-		t.Fatalf("runtime marker missing: %s", stdout.String())
+	if !strings.Contains(stdout.String(), "not selectable via providers use") {
+		t.Fatalf("non-selectable marker missing: %s", stdout.String())
 	}
 }
 

internal/cli/provider_onboarding_test.go

@@ -12,6 +12,7 @@ import (
 )
 
 func TestRunProvidersUseSetsActiveProvider(t *testing.T) {
+	t.Setenv(config.ActiveProviderEnv, "")
 	var stdout bytes.Buffer
 	var stderr bytes.Buffer
 	configPath := filepath.Join(t.TempDir(), "zero", "config.json")