Skip to content

Commit 909b4cb

Browse files
committed
ci: disable credential persistence on checkout steps
Set persist-credentials: false on all six actions/checkout steps. These jobs run untrusted PR code via cargo and docker build, and checkout's default leaves the GITHUB_TOKEN in the local git config where that code could read it. None of the jobs push or otherwise need git credentials.
1 parent 9127834 commit 909b4cb

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

‎.github/workflows/pr-checks.yml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ jobs:
2626
steps:
2727
- name: Check out repository
2828
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
29+
with:
30+
persist-credentials: false
2931

3032
- name: Set up Rust toolchain
3133
uses: dtolnay/rust-toolchain@b3b07ba8b418998c39fb20f53e8b695cdcc8de1b # stable
@@ -55,6 +57,8 @@ jobs:
5557
steps:
5658
- name: Check out repository
5759
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
60+
with:
61+
persist-credentials: false
5862

5963
- name: Set up Rust toolchain
6064
uses: dtolnay/rust-toolchain@b3b07ba8b418998c39fb20f53e8b695cdcc8de1b # stable
@@ -76,6 +80,8 @@ jobs:
7680
steps:
7781
- name: Check out repository
7882
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
83+
with:
84+
persist-credentials: false
7985

8086
- name: Set up Rust toolchain
8187
uses: dtolnay/rust-toolchain@b3b07ba8b418998c39fb20f53e8b695cdcc8de1b # stable
@@ -97,6 +103,8 @@ jobs:
97103
steps:
98104
- name: Check out repository
99105
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
106+
with:
107+
persist-credentials: false
100108

101109
- name: Set up Rust toolchain
102110
uses: dtolnay/rust-toolchain@b3b07ba8b418998c39fb20f53e8b695cdcc8de1b # stable
@@ -121,6 +129,8 @@ jobs:
121129
steps:
122130
- name: Check out repository
123131
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
132+
with:
133+
persist-credentials: false
124134

125135
- name: Set up Rust 1.91
126136
uses: dtolnay/rust-toolchain@b3b07ba8b418998c39fb20f53e8b695cdcc8de1b # 1.91
@@ -142,6 +152,8 @@ jobs:
142152
steps:
143153
- name: Check out repository
144154
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
155+
with:
156+
persist-credentials: false
145157

146158
- name: Build image
147159
run: docker build -t gitlawb-node:ci-test .

0 commit comments

Comments
 (0)