Repository navigation
Commit 756c9e3
committed
style(node): correct notify-ordering comment and reuse ZERO_SHA in test
Review follow-ups on the two prior commits:
- The peer-notify ordering comment claimed peers 'already learned via the
gossip publish', but that publish is gated on a present p2p handle; with
no handle (the very case the HTTP fallback exists for) it does not run.
State the actual rationale: peer-notify is the lowest-priority best-effort
step, ordered last so it cannot delay local broadcast or anchoring.
- The all-zeros notify test still inlined the 40-hex literal; point it at the
ZERO_SHA constant like the production path.1 parent 76bba65 commit 756c9e3
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1123 | 1123 | | |
1124 | 1124 | | |
1125 | 1125 | | |
1126 | | - | |
1127 | | - | |
| 1126 | + | |
| 1127 | + | |
1128 | 1128 | | |
1129 | 1129 | | |
1130 | 1130 | | |
| |||
2010 | 2010 | | |
2011 | 2011 | | |
2012 | 2012 | | |
2013 | | - | |
| 2013 | + | |
2014 | 2014 | | |
2015 | 2015 | | |
2016 | 2016 | | |
| |||
0 commit comments