chore: bump v0.3.9, fix all clippy warnings, enforce strict CI lint (#12)

* chore: bump v0.3.9, fix all clippy warnings, enforce strict CI lint

- Bump workspace version 0.3.8 → 0.3.9
- Fix 22 clippy warnings across 17 files:
  - Replace .last() with .next_back() on DoubleEndedIterators (8 instances)
  - Remove useless .into() conversions on anyhow::Error (3)
  - Remove needless borrows in gl init (3)
  - Replace map_or with is_some_and/is_none_or (3)
  - Collapse consecutive str::replace into char array pattern (2)
  - Change &PathBuf to &Path in function signatures (2)
  - Remove dead code: unused init_bare_repo function
  - Collapse if-let into outer match arm
  - Replace vec![...] with array literal
  - Introduce RecordAnchorInput struct (10 params → 1 struct)
  - Fix always-true boolean condition in gossip task guard
- Promote clippy from advisory to strict (-D warnings) in CI

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* style: cargo fmt

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: kevincodex1

.github/workflows/pr-checks.yml

@@ -34,10 +34,8 @@ jobs:
       - name: cargo fmt --check
         run: cargo fmt --all -- --check
 
-      # TODO: tighten to `-- -D warnings` once existing lints are cleaned up
-      - name: cargo clippy (advisory)
-        run: cargo clippy --workspace --all-targets
-        continue-on-error: true
+      - name: cargo clippy
+        run: cargo clippy --workspace --all-targets -- -D warnings
 
       - name: cargo test
         run: cargo test --workspace

.gitignore

@@ -22,3 +22,4 @@ keys/
 
 # Logs
 *.log
+.openclaude-profile.json

Cargo.lock

@@ -8,7 +8,7 @@ members = [
 ]
 
 [workspace.package]
-version = "0.3.8"
+version = "0.3.9"
 edition = "2021"
 license = "MIT OR Apache-2.0"
 authors = ["gitlawb contributors"]

Cargo.toml

@@ -30,7 +30,7 @@ pub async fn list_anchors(
         .db
         .list_arweave_anchors(q.repo.as_deref(), limit)
         .await
-        .map_err(|e| crate::error::AppError::Internal(e.into()))?;
+        .map_err(crate::error::AppError::Internal)?;
 
     Ok(Json(serde_json::json!({
         "anchors": anchors,

crates/gitlawb-node/src/api/arweave.rs

@@ -70,7 +70,7 @@ pub async fn list_repo_events(
             record
                 .owner_did
                 .split(':')
-                .last()
+                .next_back()
                 .unwrap_or(&record.owner_did),
             repo_name
         )

crates/gitlawb-node/src/api/events.rs

@@ -52,7 +52,7 @@ pub async fn get_by_cid(
         .db
         .list_all_repos()
         .await
-        .map_err(|e| AppError::Internal(e.into()))?;
+        .map_err(AppError::Internal)?;
 
     for repo in &repos {
         let repo_path = match state.repo_store.acquire(&repo.owner_did, &repo.name).await {
@@ -105,7 +105,7 @@ pub async fn list_pins(State(state): State<AppState>) -> Result<Json<serde_json:
         .db
         .list_pinned_cids()
         .await
-        .map_err(|e| AppError::Internal(e.into()))?;
+        .map_err(AppError::Internal)?;
 
     Ok(Json(serde_json::json!({
         "pins": pins,

crates/gitlawb-node/src/api/ipfs.rs

@@ -125,7 +125,7 @@ pub async fn trigger_sync(State(state): State<AppState>) -> Result<Json<serde_js
             ) {
                 (Some(owner), Some(name)) => {
                     // Use short owner (last colon segment) matching DB convention
-                    let short = owner.split(':').last().unwrap_or(owner);
+                    let short = owner.split(':').next_back().unwrap_or(owner);
                     format!("{short}/{name}")
                 }
                 _ => continue,

crates/gitlawb-node/src/api/peers.rs

@@ -134,8 +134,8 @@ pub async fn list_repos(
     State(state): State<AppState>,
     Query(query): Query<ListReposQuery>,
 ) -> Result<Response> {
-    use axum::response::IntoResponse;
     use axum::http::HeaderValue;
+    use axum::response::IntoResponse;
 
     if let Some(raw_limit) = query.limit {
         let limit = raw_limit.clamp(1, 200);
@@ -513,7 +513,7 @@ pub async fn git_receive_pack(
         let owner_short = record
             .owner_did
             .split(':')
-            .last()
+            .next_back()
             .unwrap_or(&record.owner_did);
         let clone_url = format!("{}/{}/{}.git", base_url, owner_short, record.name);
 
@@ -574,7 +574,7 @@ pub async fn git_receive_pack(
             record
                 .owner_did
                 .split(':')
-                .last()
+                .next_back()
                 .unwrap_or(&record.owner_did),
             record.name
         );
@@ -706,17 +706,17 @@ pub async fn git_receive_pack(
                         Ok(tx_id) if !tx_id.is_empty() => {
                             let arweave_url = crate::arweave::arweave_url(&tx_id);
                             let _ = db_clone
-                                .record_arweave_anchor(
-                                    &repo_slug,
-                                    &owner_did_for_arweave,
+                                .record_arweave_anchor(&crate::db::RecordAnchorInput {
+                                    repo: &repo_slug,
+                                    owner_did: &owner_did_for_arweave,
                                     ref_name,
-                                    "0".repeat(64).as_str(),
+                                    old_sha: "0".repeat(64).as_str(),
                                     new_sha,
-                                    cid.as_deref(),
-                                    &tx_id,
-                                    &arweave_url,
-                                    &node_did_str,
-                                )
+                                    cid: cid.as_deref(),
+                                    irys_tx_id: &tx_id,
+                                    arweave_url: &arweave_url,
+                                    node_did: &node_did_str,
+                                })
                                 .await;
                         }
                         Ok(_) => {}
@@ -865,7 +865,7 @@ pub async fn fork_repo(
     }
 
     // Check no name conflict under the forker's ownership
-    let forker_short = forker_did.split(':').last().unwrap_or(&forker_did);
+    let forker_short = forker_did.split(':').next_back().unwrap_or(&forker_did);
     if state.db.get_repo(forker_short, &fork_name).await?.is_some() {
         return Err(AppError::BadRequest(format!(
             "you already have a repo named {fork_name}"
@@ -1018,7 +1018,7 @@ fn to_response(record: &crate::db::RepoRecord, state: &AppState, star_count: i64
     let owner_short = record
         .owner_did
         .split(':')
-        .last()
+        .next_back()
         .unwrap_or(&record.owner_did);
 
     let base_url = state

crates/gitlawb-node/src/api/repos.rs

@@ -111,9 +111,9 @@ pub fn arweave_url(tx_id: &str) -> String {
 /// Build the Irys tag header value for Arweave indexing.
 /// Format: comma-separated "name:value" pairs.
 fn build_tags_header(anchor: &RefAnchor) -> String {
-    vec![
-        format!("App-Name:gitlawb"),
-        format!("Schema:gitlawb/ref-update/v1"),
+    [
+        "App-Name:gitlawb".to_string(),
+        "Schema:gitlawb/ref-update/v1".to_string(),
         format!("Repo:{}", sanitize_tag(&anchor.repo)),
         format!("Ref:{}", sanitize_tag(&anchor.ref_name)),
         format!("SHA:{}", &anchor.new_sha[..anchor.new_sha.len().min(16)]),