-
Notifications
You must be signed in to change notification settings - Fork 152
Learn from Cheng Huang's modernization article #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
KyleAMathews
wants to merge
6
commits into
main
Choose a base branch
from
claude/cheng-huang-article-notes-iSUp7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,287
β3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by Cheng Huang's article on AI-assisted development, this introduces a contract-based testing approach for the live query system. Changes: - Add contracts.ts with precondition/postcondition/invariant utilities - Add D2 multiplicity contracts to CollectionSubscriber.sendChangesToPipeline - Add contract verification test suite (16 tests) The contracts verify: - D2 multiplicity stays at 1 for all visible items - sentToD2Keys accurately tracks keys sent to D2 pipeline - Insert/delete operations maintain consistent tracking state Contracts can be disabled in production via NODE_ENV=production for performance.
π¦ Changeset detectedLatest commit: cabc33d The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: +855 B (+0.96%) Total Size: 90.4 kB
βΉοΈ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.35 kB βΉοΈ View Unchanged
|
Introduces property-based testing to explore edge cases in the live query system. Tests use fast-check to generate random sequences of operations and verify that invariants hold across all inputs. Properties tested: - D2 multiplicity invariant (no duplicate keys) - State consistency (live query matches expected state) - Delete-insert cycles (re-insert always succeeds after delete) - Filtered query correctness (only matching items present) - Batch operation consistency (sequential vs batched produce same result) - Stress testing (100-200 operations maintain invariants) All 9 property-based tests run 100 iterations each (20 for stress tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π― Changes
β Checklist
pnpm test:pr.π Release Impact