Mouse out of bound in video and text mode.

[markzyu]

It seems that on the demo day we added too much debug info. Mouse should not be tracked under text mode. It caused the system to crash.

[markzyu]

The kernel crash was caused by using both Maybe and nullptr to determine whether getElementAtPosition succeeded.

@tengyifei which one should we use?

[tengyifei]

There must be at least one element, the desktop. Therefore getElementAtPosition must always succeed, unless you are calling it with out-of-bounds coordinates or before drawNikita

[markzyu]

Anyhow the system should crash due to Maybe unboxing, not due to dereferencing nullptr, now that Maybe type is used...

[markzyu]

Github automatically closed this...

[markzyu]

Mouse can also go out of bound in Video mode...

[Tedko]

Will it lead to crash?

On Thu, Dec 17, 2015 at 20:21 C4Phone notifications@github.com wrote:

Mouse can also go out of bound in Video mode...

—
Reply to this email directly or view it on GitHub
#70 (comment)
.

[markzyu]

No. I added some conditions. But it will print error message into text
terminal

On Thursday, December 17, 2015, Han notifications@github.com wrote:

Will it lead to crash?

On Thu, Dec 17, 2015 at 20:21 C4Phone <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Mouse can also go out of bound in Video mode...

—
Reply to this email directly or view it on GitHub
<
#70 (comment)

.

—
Reply to this email directly or view it on GitHub
#70 (comment)
.