Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"PostgreSQL 16.x"toolbar text with the database engine icon tinted with the connection's color, followed by the connection name. Multiple windows targeting the same database (prod-safe,prod-unsafe,staging,local) become distinguishable at a glance instead of all reading the same vendor + version.Calendar.appandReminders.app: the icon shape carries the engine type, the icon tint carries the user-chosen connection identity. Same rendering as the existingConnectionSidebarHeader.swiftandWelcomeConnectionRow.swift, so the connection looks consistent across sidebar, welcome screen, and toolbar.Connection Color = None, the icon falls back to the database type's brand color via the existingdisplayColorresolver, so the brand identity is preserved by default. Brand color only changes when the user opts in.@ScaledMetric.prod-safe • PostgreSQL 16.1) and the VoiceOver label (Connection: prod-safe, PostgreSQL 16.1), so the info is one hover or one screen-reader stop away.Textlabels now use.fixedSize(horizontal: true, vertical: false). Previously SwiftUI compressed flexible text inside theNSHostingControllerprincipal item before NSToolbar got a chance to evaluate intrinsic width, so a long database name would render truncated assep...even in a 1900pt-wide window.tagName: String?andconnectionState: ToolbarConnectionStateprops onConnectionStatusView(neither was rendered) and updates theTableProToolbarViewcaller to stop computing them.PostgreSQL 16.xeven whendatabaseNamewas empty, e.g. Redis or fresh Postgres) is fixed in passing by moving the divider inside theif !databaseName.isEmptybranch.Fixes #1044.
Test plan
Connection Colorset to red, orange, yellow, green respectively. Toolbar shows the same Postgres icon shape in four different tints. Tooltip on each reads<connection-name> • PostgreSQL <version>.Connection Color = None. Icon renders in the PostgreSQL brand color (#336791)."Connection: <name>, <DB type> <version>"as a single combined element.databaseName(Redis, fresh Postgres). Divider and database section drop without leaving a trailing|.sep...truncation in a normal-width window.@ScaledMetric.swiftlint lint --strict.