Compile errors when instantiating `OpenCLVector<T>`

[N-Dekker]

An attempt to instantiate OpenCLVector<T> for a specific template argument T triggers compile errors. For example:

// Template instantiation for T = float.
template class itk::OpenCLVector<float>;

VS2022 output:

ITKimprovements\itkOpenCLVector.hxx(100,42): error C2039: 'map': is not a member of 'itk::OpenCLVector<float>'
ITKimprovements\itkOpenCLVector.hxx(137,43): error C2039: 'GetLength': is not a member of 'itk::Vector<float,3>'

Affected lines of code:

elastix/Common/OpenCL/ITKimprovements/itkOpenCLVector.hxx

Line 100 in 0852e7a

const_cast<OpenCLVector<T> *>(this)->map();

elastix/Common/OpenCL/ITKimprovements/itkOpenCLVector.hxx

Line 137 in 0852e7a

this->Write(data.GetDataPointer(), data.GetLength(), offset);

I guess these errors can be fixed easily. But are the affected member functions operator[] and Write) really necessary? Or can they simply be removed?

@dpshamonin Denis, do you still remember...?

[AidynAIMedical]

Hi,

I’m running into a related issue with newer versions of Xcode (16.4) / Clang (17.0.0) while building:

no member named 'map' in 'OpenCLVector<T>'; did you mean 'Map'?

elastix/Common/OpenCL/ITKimprovements/itkOpenCLVector.hxx

Line 100 in 0852e7a

const_cast<OpenCLVector<T> *>(this)->map();

This did not occur in older versions (Xcode 16.0 / Clang 16.0.0). Am I correct in assuming this is just a case of Map instead of map? If so, is there a reason it hasn’t been changed yet? Thanks!

[N-Dekker]

@AidynAIMedical wrote:

If so, is there a reason it hasn’t been changed yet?

Thanks for asking! We left this issue unfixed, because it did not seem to bother anyone (other than myself). Until now! We did not know that it would cause compile errors from (newer versions of) Xcode!

I'm preparing a fix now...

[N-Dekker]

@AidynAIMedical I just removed the problematic operator[]overload. (Merged PR #1347 to the main branch.) Is that sufficient for you to make it work?

[AidynAIMedical]

@N-Dekker Sorry for the late reply. Yes, it did build without issues. Thank you very much for your prompt actions!