EXOSCALE: finish implementation of zone creation#3327
Closed
das7pad wants to merge 3 commits intoDNSControl:mainfrom
Closed
EXOSCALE: finish implementation of zone creation#3327das7pad wants to merge 3 commits intoDNSControl:mainfrom
das7pad wants to merge 3 commits intoDNSControl:mainfrom
Conversation
das7pad
force-pushed
the
exoscale-create-zone
branch
from
ce84530 to
6ce1319
Compare
Contributor
Author
|
I would like to clear out this PR from my list of pending PRs. @tlimoncelli please merge or close it. I do not mind either way. Thanks! |
Contributor
|
you can close it this PR #3342 fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pierre-emmanuelJ!
While reviewing all the
ZoneCreatorimplementations, I noticed that the EXOSCALE provider has an incomplete implementation forEnsureZoneExists. This PR is finishing the implementation, but I have no account with them for testing. Would you mind giving this a try and let me know how it goes? Thanks!Part of #3007