Skip to content
This repository was archived by the owner on Aug 14, 2023. It is now read-only.
This repository was archived by the owner on Aug 14, 2023. It is now read-only.

Usage of include vs. render #168

@james2doyle

Description

@james2doyle

According to the Shopify docs, we should be avoiding include (https://help.shopify.com/en/themes/liquid/tags/deprecated-tags#include) and instead using render (https://help.shopify.com/en/themes/liquid/tags/theme-tags#render).

As a reference theme this is great, but it seems to contradict the official docs.

From the docs on include:

The include tag works similarly to the render tag, but it lets the code inside of the snippet to access and overwrite the variables within its parent template. The include tag has been deprecated because the way that it handles variables reduces performance and makes theme code harder to both read and maintain.

Is this theme going to be updated to reflect that? Or is there a reason it is still using include?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions