Writing JUNO_ROOT output fails with uproot>=5.6.7

[JostMigenda]

Full error message

> sntools ~/.astropy/cache/snewpy/models/Fornax_2021/lum_spec_22M_r10000_dat.h5 --format SNEWPY-Fornax_2021 --detector JUNO -o outfile-Fornax_2021.root -m ROOT_JUNO --end 200 --randomseed 314 --channel ps --distance 100

[ps] Generated 4 particles (expected: 3.92 particles)
[ps] Generated 4 particles (expected: 3.91 particles)
[ps] Generated 3 particles (expected: 3.80 particles)
[ps] Generated 4 particles (expected: 3.16 particles)
Traceback (most recent call last):
  File "/opt/miniconda3/envs/snewpy/bin/sntools", line 7, in <module>
    sys.exit(main())
             ~~~~^^
  File "/opt/miniconda3/envs/snewpy/lib/python3.13/site-packages/sntools/genevts.py", line 86, in main
    root_outfile.mktree("SNEvents",{"nparticles": "uint64", "origPDGID":"int32", "nuE":"double", "pdgid": ("int32",(2,)),"t": ("float64",(2,)),
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                    "px": ("float64",(2,)),"py":("float64",(2,)),"pz":("float64",(2,)),"m":("float64",(2,)), "channel": "int64"})
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/miniconda3/envs/snewpy/lib/python3.13/site-packages/uproot/writing/writable.py", line 1300, in mktree
    tree = self.mktree(
        name,
    ...<5 lines>...
        resize_factor=resize_factor,
    )
  File "/opt/miniconda3/envs/snewpy/lib/python3.13/site-packages/uproot/writing/writable.py", line 1328, in mktree
    directory._cascading.add_tree(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        directory._file.sink,
        ^^^^^^^^^^^^^^^^^^^^^
    ...<6 lines>...
        resize_factor,
        ^^^^^^^^^^^^^^
    ),
    ^
  File "/opt/miniconda3/envs/snewpy/lib/python3.13/site-packages/uproot/writing/_cascade.py", line 1714, in add_tree
    tree = uproot.writing._cascadetree.Tree(
        self,
    ...<7 lines>...
        resize_factor,
    )
  File "/opt/miniconda3/envs/snewpy/lib/python3.13/site-packages/uproot/writing/_cascadetree.py", line 290, in __init__
    raise TypeError(
        f"cannot write Awkward Array type to ROOT file:\n\n    {branch_datashape!s}"
    )
TypeError: cannot write Awkward Array type to ROOT file:

    union[string, (int64)]

Minimal example:

import uproot

f = uproot.recreate("foo.root")
f.mktree("SNEvents",{"pdgid": ("int32",(2,))})

This succeeds using uproot 5.6.6 but raises a TypeError: cannot write Awkward Array type to ROOT file: union[string, (int64)] on uproot 5.6.7 and later.

According to uproot docs, the second argument to mktree should be of type dict of str → NumPy dtype/Awkward type; it looks like ("int32", (2,)) is not seen a valid NumPy/Awkward type specification.

[JostMigenda]

@mcolomerm I wonder whether just using "int32" instead of the tuple would work? In NumPy at least, that is the dtype even for a multi-dimensional array. For Awkward Array, types are a bit more complicated, e.g.,

> import awkward as ak
> array = ak.Array([[1, 4, 9], [], [16, 25]])
> array
<Array [[1, 4, 9], [], [16, 25]] type='3 * var * int64'>

… and since I don’t have access to the JUNO-internal software that needs to read in the generated files, I can’t check whether it requires a specific type. Can you look into that and try to fix this bug?

[mcolomerm]

Thanks Jost, will try with the "int32" option. Just to confirm, you mean changing: f.mktree("SNEvents",{"pdgid": ("int32",(2,))}) to f.mktree("SNEvents",{"pdgid": ("int32")}) right?. Just for more info, this is the JUNO structure:

typedef struct
{
	ULong64_t nparticles;
	Int_t pdgid[2];
	Int_t channel[2];
	Double_t px[2];	//MeV
	Double_t py[2];	//MeV
	Double_t pz[2];	//MeV
	Double_t m[2];	//MeV
	Double_t t[2];	//ns    
	Double_t nuE;	//MeV
  Int_t origPDGID; //neutrino (mu & tau = 14, anti mu & anti tau = -14)
} EVENT;

[JostMigenda]

Just to confirm, you mean changing: f.mktree("SNEvents",{"pdgid": ("int32",(2,))}) to f.mktree("SNEvents",{"pdgid": ("int32")}) right?

You don’t need the brackets around "int32" any more, since it’s no longer a tuple. Otherwise yes—and the same for channel, px, etc. (I just didn’t include them above to keep the example minimal.)

[JostMigenda]

I decided to post this as an issue on uproot as well, see scikit-hep/uproot5#1597.

Note the workaround described there: f.mktree("SNEvents", {"pdgid": np.dtype(("int32", (2,)))})
With the extra np.dtype() call, it appears to work on all uproot versions and should produce unchanged output files.

[JostMigenda]

This issue was fixed in uproot v5.7.3, so I’ve updated the dependencies in #72 and we don’t need any further changes in sntools itself.