Skip to content

Commit ce77b60

Browse files
committed
fix: narrow invalid PR association guard
1 parent 62648b5 commit ce77b60

4 files changed

Lines changed: 0 additions & 66 deletions

File tree

‎apps/web/src/lib/session-pull-requests.test.ts‎

Lines changed: 0 additions & 32 deletions
This file was deleted.

‎apps/web/src/lib/session-pull-requests.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import { ALL_REPOSITORIES } from '@roomote/types';
2-
31
type SessionPullRequest = {
42
repository: string;
53
number: number;
@@ -26,7 +24,6 @@ export function getSessionPullRequests(
2624
for (const pullRequest of task.pullRequests) {
2725
if (
2826
!pullRequest.repository ||
29-
pullRequest.repository === ALL_REPOSITORIES ||
3027
pullRequest.number === null ||
3128
(pullRequest.status &&
3229
TERMINAL_PULL_REQUEST_STATUSES.has(pullRequest.status))

‎packages/communication/src/__tests__/fast-session-footer.test.ts‎

Lines changed: 0 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/communication/src/fast-session-footer.ts‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { Env } from '@roomote/env';
2-
import { ALL_REPOSITORIES } from '@roomote/types';
32
import {
43
and,
54
asc,
@@ -60,13 +59,6 @@ function collectFastSessionLinkedPrs(params: {
6059
const uniquePrs = new Map<string, ThreadReplyLinkedPr>();
6160

6261
for (const pullRequest of [...directPrs, ...(params.linkedPrs ?? [])]) {
63-
if (
64-
pullRequest.prUrl.startsWith(
65-
`https://github.com/${ALL_REPOSITORIES}/pull/`,
66-
)
67-
) {
68-
continue;
69-
}
7062
uniquePrs.set(pullRequest.prUrl, pullRequest);
7163
}
7264

0 commit comments

Comments
 (0)