fix: 🐛 handle chain 8.0.0 VenueSignersUpdated shape and index InstructionUnlocked - #341
Merged
Merged
Conversation
…tionUnlocked VenueSignersUpdated's `signers` field changed from `Vec<AccountId>` to `BTreeSet<AccountId>` on chain 8.0.0. BTreeSet extends the native Set, which has no `.map`, so handleVenueSignersUpdated threw `TypeError: o.map is not a function` on every such event and permanently stalled the indexer. Array.from handles both shapes uniformly. settlement.InstructionUnlocked was never registered as a handled event, so the indexed Instruction status stayed LockedForExecution forever after an unlock, even though the on-chain status correctly reverted to Pending. Wires it up to the existing InstructionLocked/Executed/Failed handler (same event shape) and maps it to the Created status, which is what the SDK reads back as Pending. Adds the InstructionUnlocked value to InstructionEventEnum and its DB enum migration so it can be logged as an InstructionEvent.
|
2 tasks
F-OBrien
approved these changes
Aug 24, 2026
Contributor
Author
|
/fast-forward |
Contributor
|
🎉 This PR is included in version 19.7.0-alpha.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
VenueSignersUpdated's
signersfield changed fromVec<AccountId>toBTreeSet<AccountId>on chain 8.0.0. BTreeSet extends the native Set, which has no.map, so handleVenueSignersUpdated threwTypeError: o.map is not a functionon every such event and permanently stalled the indexer. Array.from handles both shapes uniformly.settlement.InstructionUnlocked was never registered as a handled event, so the indexed Instruction status stayed LockedForExecution forever after an unlock, even though the on-chain status correctly reverted to Pending. Wires it up to the existing InstructionLocked/Executed/Failed handler (same event shape) and maps it to the Created status, which is what the SDK reads back as Pending. Adds the InstructionUnlocked value to InstructionEventEnum and its DB enum migration so it can be logged as an InstructionEvent.
Breaking Changes
JIRA Link
Checklist