Fix theoretical IOOBE race#1799
Merged
Merged
Conversation
R00tB33rMan
approved these changes
May 21, 2026
4drian3d
approved these changes
May 22, 2026
Contributor
4drian3d
left a comment
4drian3d
left a comment
There was a problem hiding this comment.
I don't think that's likely to happen, but since it's good practice, I don't see a problem with it
Contributor
Author
|
Completely agree on both counts, this effectively won't ever happen (worst case we'll abort the ping), but it's an eye sore & bad practice in its current state. |
electronicboy
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.