Skip to content

Fix SafeAreaPaddingModifier#792

Closed
Dark-Existed wants to merge 1 commit intoOpenSwiftUIProject:mainfrom
Dark-Existed:fix_safeareapaddingmodifier
Closed

Fix SafeAreaPaddingModifier#792
Dark-Existed wants to merge 1 commit intoOpenSwiftUIProject:mainfrom
Dark-Existed:fix_safeareapaddingmodifier

Conversation

@Dark-Existed
Copy link
Contributor

Fix #511

@augmentcode
Copy link

augmentcode bot commented Feb 15, 2026

🤖 Augment PR Summary

Summary: Fixes SafeAreaPaddingModifier so it no longer introduces unintended extra spacing and respects the requested edge set.

Changes: Re-enables the previously disabled UI snapshot test for #511, sets safeAreaInset spacing to 0, and ensures insets are applied only for edges included in the modifier’s edges set.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@Dark-Existed Dark-Existed deleted the fix_safeareapaddingmodifier branch February 15, 2026 09:07
@codecov
Copy link

codecov bot commented Feb 15, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.03%. Comparing base (9eb9e5d) to head (6cd610e).

Files with missing lines Patch % Lines
...wiftUICore/Layout/Modifier/InsetViewModifier.swift 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9eb9e5d) and HEAD (6cd610e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9eb9e5d) HEAD (6cd610e)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #792       +/-   ##
===========================================
- Coverage   26.22%   13.03%   -13.19%     
===========================================
  Files         654      621       -33     
  Lines       41047    37059     -3988     
===========================================
- Hits        10766     4832     -5934     
- Misses      30281    32227     +1946     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: safeAreaPadding API not working correctly

1 participant