[UT2004] Some localization questions

[chewi]

Hello. I'm trying to refresh the UT2004 packages for Gentoo Linux, using your installer as a guide. I've noticed the handling of localization files seems incomplete and inconsistent, and I'm trying to do right by our global users.

I gather the SystemLocalization folder is new to avoid duplicating the files across System, SystemARM64, etc. However, there are still a number of localization files in System, almost all duplicates of those in SystemLocalization. Some duplicates don't have the same filename casing or even the same content, e.g. System/Gameplay.est, which seems to be UTF-16, vs SystemLocalized/est/GamePlay.est, which seems to be UTF-8. I guess there's just some cleanup required here?

The Midway Unreal Anthology DVD includes what appears to be a relatively complete set of translations for Italian and French, as well as a smaller set for Korean. The ISO includes a smaller set of all these. None are included by your patch though, even though it does include other languages. What about the localized sound files that are found in most editions? Are there legal issues here?

These questions might apply to the older games too, but I haven't got to those yet.

[NeonKnightOA]

SystemLocalized has priority. There shouldn't be localization files in System. That's usually the root cause of many problems.

[chewi]

Okay, I can add the following to ut2004_special_fixes.sh, but this loses the French, Italian, and Korean translation due to them not being provided by the patch. I'll wait for an answer to the above before submitting a PR.

  # All System localizations are already in SystemLocalized except License.int
  mv "${_arg_destination%/}/System/License.int" "${_arg_destination%/}/SystemLocalized/int/"
  rm -f "${_arg_destination%/}/System"/*.{de,es,fr,in,it,ko}t

[FineWolf]

There's danger in just outright deleting all localisation files, as the installer can be run on top of an existing installation, and legacy mods would have installed their localisation files in System.

I did originally, in the fixes, detect localisation files that were both present in System and SystemLocalized, and removed the System versions, but that caused some problems, so it was left out.

[chewi]

I see, thank you. Gentoo installs to a staging area first and the data is installed to a system-wide non-user-writable area anyway, so users are not expected to puts mods there. I have already written code to rearrange these files, so I'll keep that.

I'm still curious about the additional translations and sounds files though.

[NeonKnightOA]

In that case, the installer should move all existing localization files per language to SystemLocalized/ before placing the new localizations from the patch on top of them.

This way, the existing localization files that aren't affected by the patches are safe.

[chewi]

That sounds doable, but @FineWolf seemed to imply there were other issues. I'll leave you to work that out between you.

On closer inspection, I've noticed that the localized sound files are present in almost every edition I've found (Midway, DVD, 5x CD, 6x CD) except for the OldUnreal ISO and GOG, which makes their omission is stranger.