feat: backup postgres databases owned by a specific user if PGDATABASE is not set and pg_dump is being used

Author: anantha1999

postgres-logical-backup/dump.sh

@@ -7,6 +7,7 @@ IFS=$'\n\t'
 # PGHOST PGPASSWORD
 
 ALL_DB_SIZE_QUERY="select sum(pg_database_size(datname)::numeric) from pg_database;"
+
 PG_BIN=/usr/lib/postgresql/$PG_VERSION/bin
 DUMP_SIZE_COEFF=5
 ERRORCOUNT=0
@@ -16,16 +17,16 @@ LOGICAL_BACKUP_S3_RETENTION_TIME=${LOGICAL_BACKUP_S3_RETENTION_TIME:=""}
 LOGICAL_BACKUP_S3_ENDPOINT=${LOGICAL_BACKUP_S3_ENDPOINT:-}
 
 function estimate_size {
-  "$PG_BIN"/psql -tqAc "${ALL_DB_SIZE_QUERY}"
+  psql -tqAc "${ALL_DB_SIZE_QUERY}"
 }
 
 function dump {
   echo "Taking dump from ${PGHOST} using ${USE_PG_DUMP:-pg_dumpall}"
 
   if [[ "${USE_PG_DUMP:-}" == "true" ]]; then
-    "$PG_BIN"/pg_dump
+    pg_dump --verbose
   else
-    "$PG_BIN"/pg_dumpall --exclude-database='postgres'
+    pg_dumpall --exclude-database='postgres' --verbose
   fi
 }
 
@@ -105,7 +106,7 @@ function aws_upload {
   [[ ! -z "${LOGICAL_BACKUP_S3_REGION}" ]] && args+=("--region=${LOGICAL_BACKUP_S3_REGION}")
 
   echo "Uploading dump to s3"
-  aws s3 cp - "$PATH_TO_BACKUP" "${args[@]//\'/}"
+  aws s3 cp - "$PATH_TO_BACKUP" "${args[@]}"
 }
 
 function gcs_upload {
@@ -130,6 +131,18 @@ if [ "$LOGICAL_BACKUP_PROVIDER" == "az" ]; then
   dump | compress > /tmp/azure-backup.sql.gz
   az_upload /tmp/azure-backup.sql.gz
 else
+
+  # Backup all the databases owned by the user if PGDATABASE is not set
+  if [[ "${USE_PG_DUMP:-}" == "true" ]] && [[ -z "${PGDATABASE:-}" ]]; then
+    GET_DATABASE_LIST_FOR_USER_QUERY="SELECT datname FROM pg_database WHERE datistemplate = false AND  datname = '$PGUSER';"
+    DATABASES=$(psql -U postgres -tqAc $GET_DATABASE_LIST_FOR_USER_QUERY)
+    for DB in $DATABASES; do
+      echo "Backing up $DB"
+      # We set PGDATABASE locally for each run
+      PGDATABASE=$DB dump | compress | upload
+    done
+  fi
+
   dump | compress | upload
   [[ ${PIPESTATUS[0]} != 0 || ${PIPESTATUS[1]} != 0 || ${PIPESTATUS[2]} != 0 ]] && (( ERRORCOUNT += 1 ))
   set +x