[MIG] product_contract: Migration to 19.0

bosd · bosd · commit 321af49b7004 · 2026-01-02T14:59:39.000+01:00
diff --git a/product_contract/README.rst b/product_contract/README.rst
@@ -21,13 +21,13 @@ Recurring - Product Contract
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fcontract-lightgray.png?logo=github
-    :target: https://github.com/OCA/contract/tree/18.0/product_contract
+    :target: https://github.com/OCA/contract/tree/19.0/product_contract
     :alt: OCA/contract
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-product_contract
+    :target: https://translation.odoo-community.org/projects/contract-19-0/contract-19-0-product_contract
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/contract&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/contract&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -68,7 +68,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/contract/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/contract/issues/new?body=module:%20product_contract%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/contract/issues/new?body=module:%20product_contract%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -115,6 +115,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-sbejaoui| 
 
-This module is part of the `OCA/contract <https://github.com/OCA/contract/tree/18.0/product_contract>`_ project on GitHub.
+This module is part of the `OCA/contract <https://github.com/OCA/contract/tree/19.0/product_contract>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
diff --git a/product_contract/__manifest__.py b/product_contract/__manifest__.py
@@ -4,7 +4,7 @@
 
 {
     "name": "Recurring - Product Contract",
-    "version": "18.0.1.1.2",
+    "version": "19.0.1.0.0",
     "category": "Contract Management",
     "license": "AGPL-3",
     "author": "LasLabs, ACSONE SA/NV, Odoo Community Association (OCA)",
diff --git a/product_contract/migrations/18.0.1.0.0/post-migration.py b/product_contract/migrations/18.0.1.0.0/post-migration.py
diff --git a/product_contract/migrations/18.0.1.0.0/pre-migrate.py b/product_contract/migrations/18.0.1.0.0/pre-migrate.py
diff --git a/product_contract/models/contract.py b/product_contract/models/contract.py
@@ -3,7 +3,6 @@
 
 from odoo import api, fields, models
 from odoo.exceptions import AccessError
-from odoo.tools.translate import _
 
 
 class ContractContract(models.Model):
@@ -26,7 +25,7 @@ def action_view_sales_orders(self):
         self.ensure_one()
         orders = self.contract_line_ids.mapped("sale_order_line_id.order_id")
         action = {
-            "name": _("Sales Orders"),
+            "name": self.env._("Sales Orders"),
             "view_mode": "list,form",
             "res_model": "sale.order",
             "type": "ir.actions.act_window",
diff --git a/product_contract/models/product_template.py b/product_contract/models/product_template.py
@@ -2,7 +2,7 @@
 # Copyright 2018 ACSONE SA/NV.
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import ValidationError
 
 
@@ -154,10 +154,21 @@ class ProductTemplate(models.Model):
 
     def write(self, vals):
         if "is_contract" in vals and vals["is_contract"] is False:
-            for company in self.env["res.company"].search([]):
-                self.with_company(company).write(
-                    {"property_contract_template_id": False}
+            # Get only the IDs to avoid loading all company records into memory
+            # Use a reasonable batch size to avoid performance issues
+            offset = 0
+            batch_size = 100
+            while True:
+                company_batch = self.env["res.company"].search_read(
+                    [], ["id"], offset=offset, limit=batch_size, order="id"
                 )
+                if not company_batch:
+                    break
+                for company_data in company_batch:
+                    self.with_company(company_data["id"]).write(
+                        {"property_contract_template_id": False}
+                    )
+                offset += batch_size
         return super().write(vals)
 
     @api.constrains("is_contract", "type")
@@ -166,4 +177,4 @@ def _check_contract_product_type(self):
         Contract product should be service type
         """
         if any([product.is_contract and product.type != "service" for product in self]):
-            raise ValidationError(_("Contract product should be service type"))
+            raise ValidationError(self.env._("Contract product should be service type"))
diff --git a/product_contract/models/sale_order.py b/product_contract/models/sale_order.py
@@ -2,7 +2,7 @@
 # Copyright 2018 ACSONE SA/NV.
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import ValidationError
 
 
@@ -22,7 +22,7 @@ def _check_contact_is_not_terminated(self):
                 "cancel",
             ) and rec.order_line.filtered("contract_id.is_terminated"):
                 raise ValidationError(
-                    _("You can't upsell or downsell a terminated contract")
+                    self.env._("You can't upsell or downsell a terminated contract")
                 )
 
     @api.depends("order_line.contract_id", "state")
diff --git a/product_contract/models/sale_order_line.py b/product_contract/models/sale_order_line.py
@@ -4,7 +4,7 @@
 
 from dateutil.relativedelta import relativedelta
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import ValidationError
 
 MONTH_NB_MAPPING = {
@@ -27,7 +27,7 @@ def _check_contact_is_not_terminated(self):
                 and rec.contract_id.is_terminated
             ):
                 raise ValidationError(
-                    _("You can't upsell or downsell a terminated contract")
+                    self.env._("You can't upsell or downsell a terminated contract")
                 )
 
     def _get_contract_line_qty(self):
@@ -63,7 +63,7 @@ def _prepare_contract_line_values(
             "product_id": self.product_id.id,
             "name": self.name.split(":\n")[0],
             "quantity": self._get_contract_line_qty(),
-            "uom_id": self.product_uom.id,
+            "uom_id": self.product_uom_id.id,
             "price_unit": self.price_unit,
             "discount": self.discount,
             "date_end": self.date_end,
@@ -123,7 +123,7 @@ def _check_contract_sale_partner(self):
             if rec.contract_id:
                 if rec.order_id.partner_id != rec.contract_id.partner_id:
                     raise ValidationError(
-                        _(
+                        self.env._(
                             "Sale Order and contract should be "
                             "linked to the same partner"
                         )
@@ -138,7 +138,7 @@ def _check_contract_sale_contract_template(self):
                     and rec.contract_template_id != rec.contract_id.contract_template_id
                 ):
                     raise ValidationError(
-                        _("Contract product has different contract template")
+                        self.env._("Contract product has different contract template")
                     )
 
     def _compute_invoice_status(self):
@@ -271,7 +271,7 @@ def _get_contract_name(self, date_text, recurring_rule_label, invoicing_type_lab
 
     def _get_contract_name_format(self):
         self.ensure_one()
-        return _(
+        return self.env._(
             """{product}:
             - Recurrency: {recurring_rule}
             - Invoicing Type: {invoicing_type}
diff --git a/product_contract/static/description/index.html b/product_contract/static/description/index.html
@@ -374,7 +374,7 @@ <h1>Recurring - Product Contract</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:34494a98ca456e25a227778a7bf16f4107e7ca5893c8e264d62de0558186fa64
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/contract/tree/18.0/product_contract"><img alt="OCA/contract" src="https://img.shields.io/badge/github-OCA%2Fcontract-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-product_contract"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/contract&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/contract/tree/19.0/product_contract"><img alt="OCA/contract" src="https://img.shields.io/badge/github-OCA%2Fcontract-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/contract-19-0/contract-19-0-product_contract"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/contract&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module adds support for products to be linked to contract
 templates.</p>
 <p>A contract is created on <tt class="docutils literal">sale.order</tt> confirmation for each different
@@ -417,7 +417,7 @@ <h2><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/contract/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/contract/issues/new?body=module:%20product_contract%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/contract/issues/new?body=module:%20product_contract%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -454,7 +454,7 @@ <h3><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h3>
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/sbejaoui"><img alt="sbejaoui" src="https://github.com/sbejaoui.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/contract/tree/18.0/product_contract">OCA/contract</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/contract/tree/19.0/product_contract">OCA/contract</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
diff --git a/product_contract/static/src/xml/sale_product_field.xml b/product_contract/static/src/xml/sale_product_field.xml
@@ -2,7 +2,7 @@
 <templates xml:space="preserve">
 
     <t t-inherit="sale.SaleProductField" t-inherit-mode="extension">
-        <xpath expr="//button[@t-if='hasExternalButton']" position="before">
+        <xpath expr="//button[@t-on-click='onEditConfiguration']" position="before">
             <t t-if="isConfigurableContract">
                 <button
                     type="button"
diff --git a/product_contract/tests/test_product.py b/product_contract/tests/test_product.py
@@ -17,8 +17,12 @@ def setUpClass(cls):
                 no_reset_password=True,
             )
         )
-        cls.service_product = cls.env.ref("product.product_product_1")
-        cls.consu_product = cls.env.ref("product.product_product_5")
+        cls.service_product = cls.env["product.product"].create(
+            {"name": "Test Service", "type": "service"}
+        )
+        cls.consu_product = cls.env["product.product"].create(
+            {"name": "Test Consumable", "type": "consu"}
+        )
         cls.contract = cls.env["contract.template"].create({"name": "Test"})
 
     def test_change_is_contract(self):
diff --git a/product_contract/tests/test_sale_order.py b/product_contract/tests/test_sale_order.py
@@ -22,10 +22,63 @@ def setUpClass(cls):
                 no_reset_password=True,
             )
         )
-        cls.partner = cls.env["res.partner"].create({"name": "Test partner"})
-        cls.product1 = cls.env.ref("product.product_product_1")
-        cls.product2 = cls.env.ref("product.product_product_2")
-        cls.sale = cls.env.ref("sale.sale_order_2")
+        cls.partner = cls.env["res.partner"].create(
+            {
+                "name": "Test partner",
+            }
+        )
+        cls.product1 = cls.env["product.product"].create(
+            {
+                "name": "Contract Product 1",
+                "type": "service",
+                "lst_price": 100.0,
+            }
+        )
+        cls.product2 = cls.env["product.product"].create(
+            {
+                "name": "Contract Product 2",
+                "type": "service",
+                "lst_price": 50.0,
+            }
+        )
+        cls.sale = cls.env["sale.order"].create(
+            {
+                "partner_id": cls.partner.id,
+                "order_line": [
+                    (
+                        0,
+                        0,
+                        {
+                            "product_id": cls.product1.id,
+                            "product_uom_qty": 1,
+                        },
+                    ),
+                    (
+                        0,
+                        0,
+                        {
+                            "product_id": cls.product2.id,
+                            "product_uom_qty": 1,
+                        },
+                    ),
+                ],
+            }
+        )
+        cls.account = cls.env["account.account"].create(
+            {
+                "name": "Contract Account",
+                "code": "4000",
+                "account_type": "asset_current",
+                "reconcile": True,
+            }
+        )
+        cls.journal = cls.env["account.journal"].create(
+            {
+                "name": "Contract Journal",
+                "type": "sale",
+                "default_account_id": cls.account.id,
+            }
+        )
         cls.contract_template1 = cls.env["contract.template"].create(
             {"name": "Template 1"}
         )
diff --git a/product_contract/views/sale_order.xml b/product_contract/views/sale_order.xml
@@ -52,7 +52,7 @@
                 />
             </xpath>
             <xpath
-                expr="//field[@name='order_line']/form//field[@name='tax_id']/parent::group"
+                expr="//field[@name='order_line']/form//field[@name='tax_ids']/parent::group"
                 position="after"
             >
                 <field name="is_contract" invisible="1" />
diff --git a/test-requirements.txt b/test-requirements.txt
@@ -0,0 +1,3 @@
+odoo-addon-contract @ git+https://github.com/OCA/contract@refs/pull/1312/head#subdirectory=contract
+odoo-addon-contract_termination @ git+https://github.com/OCA/contract@refs/pull/1367/head#subdirectory=contract_termination
+odoo-addon-contract_line_successor @ git+https://github.com/OCA/contract@refs/pull/1370/head#subdirectory=contract_line_successor

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`{`
`6`	`6`	`"name": "Recurring - Product Contract",`
`7`		`- "version": "18.0.1.1.2",`
	`7`	`+ "version": "19.0.1.0.0",`
`8`	`8`	`"category": "Contract Management",`
`9`	`9`	`"license": "AGPL-3",`
`10`	`10`	`"author": "LasLabs, ACSONE SA/NV, Odoo Community Association (OCA)",`