Repository navigation
Commit 9cef5ec
committed
T1.24b: the bridge freeze reads the checked tree's allowances
bridge_freeze.py granted allowances from the running copy of itself. The
gate runs its checkpoint's copy over a candidate's tree, so it granted
none of the candidate's, and an allowance landed beforehand is spent at
the base and grants nothing either: no allowance could ever pass the
gate. Shown by T1.24b's candidate (CI run 38205702823): every check but
the gate's l0, which refused the three setters' allowances under E66(g).
problems(), which l0_deps.py runs, now reads the checked tree's own copy
of ALLOWANCES (tree_allowances; a copy missing, unparsed or not a literal
is refused). So a candidate's own ALLOWANCES can grant an allowance. The
safeguards: each entry must name a row the owner approved in the base's
decisions.md; bridge_freeze.py is a protected path a landing must name;
reviewers check every entry; E56(d) retires the allowances at T1.28b.
selftest.py seeds the reading (the tree's allowances, not the running
copy's; not a literal; the script missing) and fixes a self-test bug:
its allowance seeds replaced only an empty ALLOWANCES literal, so they
failed once the script held any entry (allowances_as replaces the whole
assignment). A bug fix to a frozen guard (E56(a)), part 1 of T1.24b; it
adds no allowance.
Refs: T1.10e, T1.14
Signed-off-by: Adi Wadaskar <awadaskar@nvidia.com>1 parent b455b94 commit 9cef5ec
2 files changed
Lines changed: 110 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
85 | 92 | | |
86 | 93 | | |
87 | 94 | | |
| |||
903 | 910 | | |
904 | 911 | | |
905 | 912 | | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
906 | 959 | | |
907 | 960 | | |
908 | 961 | | |
| |||
1322 | 1375 | | |
1323 | 1376 | | |
1324 | 1377 | | |
1325 | | - | |
| 1378 | + | |
| 1379 | + | |
| 1380 | + | |
| 1381 | + | |
1326 | 1382 | | |
1327 | 1383 | | |
1328 | 1384 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
653 | 653 | | |
654 | 654 | | |
655 | 655 | | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
656 | 673 | | |
657 | 674 | | |
658 | 675 | | |
| |||
661 | 678 | | |
662 | 679 | | |
663 | 680 | | |
664 | | - | |
665 | | - | |
666 | | - | |
667 | | - | |
| 681 | + | |
668 | 682 | | |
669 | 683 | | |
670 | 684 | | |
| |||
1877 | 1891 | | |
1878 | 1892 | | |
1879 | 1893 | | |
1880 | | - | |
1881 | | - | |
1882 | | - | |
1883 | | - | |
| 1894 | + | |
1884 | 1895 | | |
1885 | 1896 | | |
1886 | 1897 | | |
1887 | 1898 | | |
1888 | 1899 | | |
| 1900 | + | |
| 1901 | + | |
| 1902 | + | |
| 1903 | + | |
| 1904 | + | |
| 1905 | + | |
| 1906 | + | |
| 1907 | + | |
| 1908 | + | |
| 1909 | + | |
| 1910 | + | |
| 1911 | + | |
| 1912 | + | |
| 1913 | + | |
| 1914 | + | |
| 1915 | + | |
| 1916 | + | |
| 1917 | + | |
| 1918 | + | |
| 1919 | + | |
| 1920 | + | |
| 1921 | + | |
| 1922 | + | |
| 1923 | + | |
| 1924 | + | |
| 1925 | + | |
| 1926 | + | |
| 1927 | + | |
| 1928 | + | |
| 1929 | + | |
| 1930 | + | |
| 1931 | + | |
| 1932 | + | |
1889 | 1933 | | |
1890 | 1934 | | |
1891 | 1935 | | |
| |||
0 commit comments