Skip to content

Commit 6a46b4e

Browse files
committed
T1.32e: the route tests' step on one line again; prepush self-tests on ci.yml changes
Round 3's subagent review of 0137286 (P1): selftest.py edits a copy of ci.yml at the exact line ` run: python -m pytest contract/tests -q`, which the step's multi-line `run: |` had removed, so CI's L0 self-tests failed. The step is one line again, with the same options: `-n auto --dist loadfile --timeout=600 --max-worker-restart=0`. selftest.py: 497 of 497 as expected. P3: prepush.sh's cheap tier now also runs the tooling self-tests when .github/workflows/ci.yml changed, since they read it; its comment and skip line say so. Signed-off-by: Adi Wadaskar <awadaskar@nvidia.com>
1 parent 988a54e commit 6a46b4e

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -663,9 +663,7 @@ jobs:
663663
# with its stack, and a worker that dies ends the run rather than
664664
# leaving xdist waiting on it.
665665
- name: The runner's controls and the route tests
666-
run: |
667-
python -m pytest contract/tests -q -n auto --dist loadfile \
668-
--timeout=600 --max-worker-restart=0
666+
run: python -m pytest contract/tests -q -n auto --dist loadfile --timeout=600 --max-worker-restart=0
669667
# As in rust-test, whether the gate runs fails closed (T1.18); off
670668
# the phase branch, the candidate's own runners and comparator run.
671669
# Every cell gates, the floor's too (T1.18's own run alone reported

‎scripts/rust_core/prepush.sh‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@
2323
# prune_caches.py.
2424
#
2525
# The cheap tier skips those four self-tests only when no file under
26-
# scripts/rust_core/ differs between the merge base with the phase branch
26+
# scripts/rust_core/, nor .github/workflows/ci.yml, which they read, differs
27+
# between the merge base with the phase branch
2728
# (origin/rust-core-phase-1, else rust-core-phase-1) and the worktree,
2829
# committed, uncommitted or untracked, nor, under the hook, between each ref
2930
# pushed and its own merge base; any change there runs all four, since the
@@ -182,10 +183,11 @@ if [ -n "$base" ] && [ "$pushed_refs" = 1 ]; then
182183
done <"$logdir/pushed-refs"
183184
fi
184185
# The tooling self-tests run unless there is a merge base, the tier is
185-
# cheap and nothing under scripts/rust_core/ changed.
186+
# cheap and nothing under scripts/rust_core/ changed, nor CI's workflow,
187+
# which the self-tests read.
186188
run_selftests=1
187189
if [ "$full" = 0 ] && [ -n "$base" ] &&
188-
! grep -q '^scripts/rust_core/' <<<"$changed"; then
190+
! grep -qE '^(scripts/rust_core/|\.github/workflows/ci\.yml$)' <<<"$changed"; then
189191
run_selftests=0
190192
fi
191193
skipped=()
@@ -225,7 +227,7 @@ selftest 'replay_jobs.py self-tests' \
225227
selftest 'prune_caches.py self-tests' \
226228
"${py[@]}" scripts/rust_core/prune_caches.py --selftest
227229
if [ "${#skipped[@]}" -gt 0 ]; then
228-
echo "skipped, nothing under scripts/rust_core/ changed since the merge base ${base:0:10} with $phase_ref:" \
230+
echo "skipped, nothing under scripts/rust_core/ nor ci.yml changed since the merge base ${base:0:10} with $phase_ref:" \
229231
"$(IFS=,; echo "${skipped[*]}" | sed 's/,/, /g')"
230232
fi
231233

0 commit comments

Comments
 (0)