Repository navigation
Commit 4da0bf6
committed
T2.9 fix 1: an average's, a minimum's or a maximum's lag on its own row
The reference's engine labels each lag through execute_join, which drops
the examples whose window holds no value, and lines the values up by
position in its frame of the lags, so an average's, a minimum's or a
maximum's lagged values move to the first rows rather than their own,
and the last rows (often the entities predicted for) get none. Decided by
the orchestrator under the owner's standing delegation (KO2-70,
2026-10-19): each value goes on its own row.
- sdm-core's lag::Lag::columns places each label by the labels' mask on
the example it belongs to; an example whose window holds none has none.
A sum's and a count's lags, every example's, are unchanged.
- Tests of my own reading: lag.rs's a_maximum_s_values_keep_their_rows_
across_gaps (a value, a gap, a value, over two steps, rows kept in a
request's order, a sum beside it) and the average's test, now on its own
row; the route test test_an_average_s_lag_is_each_row_s_own_window
(each predicted row's lag its own window's average, read from the data
with DuckDB; the rest of the request equal to the old route's), in place
of the average's old-route equality.
- The 40-source differential again: every payload difference is an
average's, a minimum's or a maximum's lag column or a comparison of one.
Its register entry and P2B-19's approval cite KO2-70, which is not on the
phase head yet; they follow in their own commit once it is (tracker).
Signed-off-by: Adi Wadaskar <awadaskar@nvidia.com>1 parent ae82784 commit 4da0bf6
3 files changed
Lines changed: 131 additions & 28 deletions
File tree
- docs/design/rust-core/phase-2
- packages/structured-data-models-client/tests
- rust/crates/sdm-core/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | | - | |
42 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
43 | 45 | | |
44 | 46 | | |
45 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
202 | | - | |
203 | 202 | | |
204 | 203 | | |
205 | 204 | | |
| |||
217 | 216 | | |
218 | 217 | | |
219 | 218 | | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
220 | 269 | | |
221 | 270 | | |
222 | 271 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
202 | 212 | | |
203 | 213 | | |
204 | 214 | | |
| |||
264 | 274 | | |
265 | 275 | | |
266 | 276 | | |
267 | | - | |
268 | | - | |
269 | | - | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
270 | 281 | | |
271 | | - | |
| 282 | + | |
272 | 283 | | |
273 | 284 | | |
274 | 285 | | |
| |||
286 | 297 | | |
287 | 298 | | |
288 | 299 | | |
289 | | - | |
| 300 | + | |
290 | 301 | | |
291 | 302 | | |
292 | 303 | | |
293 | 304 | | |
294 | 305 | | |
295 | 306 | | |
296 | | - | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
297 | 345 | | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
298 | 350 | | |
299 | | - | |
300 | | - | |
| 351 | + | |
| 352 | + | |
301 | 353 | | |
302 | 354 | | |
303 | 355 | | |
| |||
0 commit comments