Merge branch 'main' into fix/pe3-env-lookbehind-and-reference-dir

Author: rng1995

src/skillspector/nodes/analyzers/static_patterns_excessive_agency.py

@@ -42,7 +42,7 @@
 
 # EA1: Unrestricted Tool Access
 EA1_PATTERNS = [
-    (r"(?:tools?|permissions?)\s*:\s*\[?\s*['\"]?\*['\"]?\s*\]?", 0.85),
+    (r"(?:tools?|permissions?)\s*:[ \t]*\[?[ \t]*['\"]?\*(?!\*|\w)['\"]?[ \t]*\]?", 0.85),
     (r"(?:allow|grant|enable)\s+(?:access\s+to\s+)?(?:all|any|every)\s+tools?", 0.8),
     (
         r"(?:no|without)\s+(?:tool|permission|access|capability)\s+(?:restrictions?|constraints?|limitations?)",

tests/nodes/analyzers/test_ea1_wildcard_line_boundary.py

@@ -0,0 +1,116 @@
+# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: Apache-2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Tests for EA1's wildcard-tool-access pattern: line-boundary and bold-markdown fixes.
+
+Confirmed on the official anthropics/skills repo, mcp-builder/SKILL.md:
+the original EA1 regex used bare ``\\s*`` between the colon and the expected
+wildcard value. Because Python's ``\\s`` matches newlines, the gap could span
+a blank line and bridge two unrelated headings (SKILL.md:96, "For each
+tool:" + blank line + "**Input Schema:**"). The pattern also had no check
+that the matched ``*`` was a standalone token, so the first ``*`` of a
+closing ``**`` bold-markdown span satisfied it (SKILL.md:25, "**API Coverage
+vs. Workflow Tools:**"). Both false positives fired as EA1/MEDIUM and
+survived to the final report.
+"""
+
+from __future__ import annotations
+
+from skillspector.nodes.analyzers import (
+    static_patterns_excessive_agency as ea_module,
+)
+
+
+class TestEA1LineBoundary:
+    """The wildcard value must be on the same line as the colon, not bridged
+    across a blank line to an unrelated heading."""
+
+    def test_heading_intro_followed_by_blank_line_and_next_heading_not_flagged(self) -> None:
+        findings = ea_module.analyze(
+            "For each tool:\n\n**Input Schema:**\n",
+            "SKILL.md",
+            "markdown",
+        )
+        assert not any(f.rule_id == "EA1" for f in findings)
+
+    def test_wildcard_on_next_line_without_blank_gap_still_not_flagged(self) -> None:
+        """The value must be on the *same* line as the colon; even a single
+        newline before it is not a same-line wildcard grant."""
+        findings = ea_module.analyze(
+            "tools:\n*\n",
+            "SKILL.md",
+            "markdown",
+        )
+        assert not any(f.rule_id == "EA1" for f in findings)
+
+
+class TestEA1BoldMarkdownCollision:
+    """The matched ``*`` must be a standalone token, not the first asterisk
+    of a ``**bold**`` span."""
+
+    def test_bold_heading_ending_in_tools_colon_not_flagged(self) -> None:
+        findings = ea_module.analyze(
+            "**API Coverage vs. Workflow Tools:**\n",
+            "SKILL.md",
+            "markdown",
+        )
+        assert not any(f.rule_id == "EA1" for f in findings)
+
+    def test_bolded_list_of_named_tools_not_flagged(self) -> None:
+        """A bolded list of specific tools is the opposite of an unrestricted
+        grant and must not match."""
+        findings = ea_module.analyze(
+            "Tools: **Read**, **Write**\n",
+            "SKILL.md",
+            "markdown",
+        )
+        assert not any(f.rule_id == "EA1" for f in findings)
+
+
+class TestEA1GenuineWildcardStillFlagged:
+    """Real single-line wildcard grants must still fire — the fix narrows
+    the pattern, it must not blind it."""
+
+    def test_tools_quoted_wildcard_flagged(self) -> None:
+        findings = ea_module.analyze(
+            'tools: "*"\n',
+            "SKILL.md",
+            "markdown",
+        )
+        assert any(f.rule_id == "EA1" for f in findings)
+
+    def test_tools_bracketed_wildcard_flagged(self) -> None:
+        findings = ea_module.analyze(
+            "tools: [*]\n",
+            "SKILL.md",
+            "markdown",
+        )
+        assert any(f.rule_id == "EA1" for f in findings)
+
+    def test_permissions_single_quoted_wildcard_flagged(self) -> None:
+        findings = ea_module.analyze(
+            "permissions: '*'\n",
+            "SKILL.md",
+            "markdown",
+        )
+        assert any(f.rule_id == "EA1" for f in findings)
+
+    def test_unquoted_wildcard_flagged(self) -> None:
+        findings = ea_module.analyze(
+            "tools: *\n",
+            "SKILL.md",
+            "markdown",
+        )
+        assert any(f.rule_id == "EA1" for f in findings)