Missing Slack notifications for Sunlight plan enrollment

[duckduckgrayduck]

I suspect that this is happening when an org signs up from /selectplan/, we receive no notification that they have subscribed.

[allanlasser]

It could be that the "Slack Webhook URL" field isn't set on a particular plan—I believe this notification should be sent regardless of where the subscription was purchased.

squarelet/squarelet/organizations/models/payment.py

Lines 328 to 329 in 59a6c91

	# Slack notification for new subscription
	self.send_slack_notification("started")

squarelet/squarelet/organizations/models/payment.py

Lines 452 to 521 in 59a6c91

	def send_slack_notification(self, event, **kwargs):
	"""Queue a Slack notification asynchronously for subscription events."""
	if not is_production_env():
	return
	if not self.plan.slack_webhook_url:
	return
	# Squarelet
	from squarelet.organizations.tasks import ( # pylint:disable=import-outside-toplevel
	send_slack_notification,
	)
	# Link to the organization
	org_url = self.organization.get_absolute_url()
	domain = getattr(
	settings, "SQUARELET_URL", "https://accounts.muckrock.com"
	).rstrip(
	"/"
	) # avoid double slashes
	org_link = (
	f"<{domain}{org_url}|{self.organization.name}>"
	if org_url
	else self.organization.name
	)
	event_messages = {
	"started": {
	"subject": "New Subscription",
	"message": (
	f"{org_link} has just subscribed to "
	f"the *{self.plan.name}* plan."
	),
	},
	"cancelled": {
	"subject": "Subscription Cancelled",
	"message": (
	f"{org_link} has cancelled their subscription "
	f"to the *{self.plan.name}* plan."
	),
	},
	}
	if event not in event_messages:
	logger.warning("Unknown subscription event: %s", event)
	return
	event_data = event_messages[event]
	subject = event_data["subject"]
	message = event_data["message"]
	# Build the base section block
	section_block = {
	"type": "section",
	"text": {"type": "mrkdwn", "text": f"*{subject}*\n\n{message}"},
	"accessory": {
	"type": "image",
	"image_url": self.organization.avatar_url,
	"alt_text": f"{self.organization.name} avatar",
	},
	}
	slack_message = {
	"text": f"{subject}\n\n{message}", # Fallback text for notifications
	"blocks": [section_block],
	}
	send_slack_notification.delay(
	self.plan.slack_webhook_url, subject, slack_message
	)

[duckduckgrayduck]

Here is an example:
Arizona Luminaria mistakenly signed up for Sunlight Essential (Non-profit) plan. This correctly sent a Slack notification to us. They later realized this mistake and correctly changed the plan to the Election Accountability Cohort Plan, which we didn't get a notification for. The Slack webhook URL is set for both plans