Skip to content

Commit aa60d91

Browse files
author
konghuanjun
committed
test(tower): stub ILogService in every AgentTowerService test scope
The fork-restore tests build second DI scopes that register AgentTowerService without stubbing ILogService, leaving this.log undefined. When reconcileForeignTower fires a fire-and-forget exit and the ownership release rejects, the rejection handler's this.log.warn throws a TypeError that surfaces as an unhandled rejection in the full suite. Add ix2.stub(ILogService, stubLog()) to all nine scopes that lacked it, matching the existing sibling pattern.
1 parent 61b167e commit aa60d91

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

‎packages/agent-core-v2/test/features/tower/towerService.test.ts‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1872,6 +1872,7 @@ describe('AgentTowerService', () => {
18721872
ix2.stub(IAgentToolApprovalService, { formatDenyMessage });
18731873
ix2.stub(ITelemetryService, { track2: () => {} });
18741874
ix2.stub(IFlagService, stubFlag((id) => id === TOWER_FLAG_ID));
1875+
ix2.stub(ILogService, stubLog());
18751876
ix2.stub(ISessionContext, { cwd: '/nonexistent-tower-repo' } as unknown as ISessionContext);
18761877
ix2.stub(
18771878
IAgentReminderService,
@@ -1973,6 +1974,7 @@ describe('AgentTowerService', () => {
19731974
ix2.stub(IAgentToolApprovalService, { formatDenyMessage });
19741975
ix2.stub(ITelemetryService, { track2: () => {} });
19751976
ix2.stub(IFlagService, stubFlag(() => false));
1977+
ix2.stub(ILogService, stubLog());
19761978
ix2.stub(ISessionContext, { cwd: '/nonexistent-tower-repo' } as unknown as ISessionContext);
19771979
ix2.stub(
19781980
IAgentReminderService,
@@ -2039,6 +2041,7 @@ describe('AgentTowerService', () => {
20392041
ix2.stub(IAgentToolApprovalService, { formatDenyMessage });
20402042
ix2.stub(ITelemetryService, { track2: () => {} });
20412043
ix2.stub(IFlagService, stubFlag((id) => id === TOWER_FLAG_ID));
2044+
ix2.stub(ILogService, stubLog());
20422045
ix2.stub(ISessionContext, { cwd: '/nonexistent-tower-repo' } as unknown as ISessionContext);
20432046
ix2.stub(
20442047
IAgentReminderService,
@@ -2112,6 +2115,7 @@ describe('AgentTowerService', () => {
21122115
ix2.stub(IAgentToolApprovalService, { formatDenyMessage });
21132116
ix2.stub(ITelemetryService, { track2: () => {} });
21142117
ix2.stub(IFlagService, stubFlag((id) => id === TOWER_FLAG_ID));
2118+
ix2.stub(ILogService, stubLog());
21152119
ix2.stub(ISessionManager, {
21162120
get: (id: string) => (id === 'session-original' ? {} : undefined),
21172121
} as unknown as ISessionManager);
@@ -2222,6 +2226,7 @@ describe('AgentTowerService', () => {
22222226
ix2.stub(IAgentToolApprovalService, { formatDenyMessage });
22232227
ix2.stub(ITelemetryService, { track2: () => {} });
22242228
ix2.stub(IFlagService, stubFlag((id) => id === TOWER_FLAG_ID));
2229+
ix2.stub(ILogService, stubLog());
22252230
ix2.stub(ISessionManager, {
22262231
get: () => undefined,
22272232
} as unknown as ISessionManager);
@@ -2406,6 +2411,7 @@ describe('AgentTowerService', () => {
24062411
ix2.stub(IAgentToolApprovalService, { formatDenyMessage });
24072412
ix2.stub(ITelemetryService, { track2: () => {} });
24082413
ix2.stub(IFlagService, stubFlag(() => false));
2414+
ix2.stub(ILogService, stubLog());
24092415
ix2.stub(ISessionManager, {
24102416
get: (id: string) => (id === 'session-original' ? {} : undefined),
24112417
} as unknown as ISessionManager);
@@ -2486,6 +2492,7 @@ describe('AgentTowerService', () => {
24862492
ix2.stub(IAgentToolApprovalService, { formatDenyMessage });
24872493
ix2.stub(ITelemetryService, { track2: () => {} });
24882494
ix2.stub(IFlagService, stubFlag((id) => id === TOWER_FLAG_ID));
2495+
ix2.stub(ILogService, stubLog());
24892496
ix2.stub(ISessionManager, {
24902497
get: (id: string) => (id === 'session-original' ? {} : undefined),
24912498
} as unknown as ISessionManager);
@@ -2562,6 +2569,7 @@ describe('AgentTowerService', () => {
25622569
ix2.stub(IAgentToolApprovalService, { formatDenyMessage });
25632570
ix2.stub(ITelemetryService, { track2: () => {} });
25642571
ix2.stub(IFlagService, stubFlag((id) => id === TOWER_FLAG_ID));
2572+
ix2.stub(ILogService, stubLog());
25652573
ix2.stub(ISessionContext, {
25662574
cwd: '/nonexistent-tower-repo',
25672575
sessionId: 'session-owner',
@@ -2619,6 +2627,7 @@ describe('AgentTowerService', () => {
26192627
ix2.stub(IAgentToolApprovalService, { formatDenyMessage });
26202628
ix2.stub(ITelemetryService, { track2: () => {} });
26212629
ix2.stub(IFlagService, stubFlag((id) => id === TOWER_FLAG_ID));
2630+
ix2.stub(ILogService, stubLog());
26222631
ix2.stub(ISessionContext, { cwd: '/nonexistent-tower-repo' } as unknown as ISessionContext);
26232632
ix2.stub(
26242633
IAgentReminderService,

0 commit comments

Comments
 (0)